jdk11u-dev
jdk11u-dev copied to clipboard
8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows
Backport of JDK-8253980
- This PR contains two commits
- Commit 1: is a de facto clean back port of original commit
-
bug7158712.java
is a cleangit apply
-
ProblemList.txt
is a manual change based on original commit, can beconsidered as clean
-
- Commit 2
- A line
popup.show()
has been added to avoid the test case failure with message:- IllegalComponentStateException: component must be showing on the screen to determine its location
- A line
Testing
- Local: Test passed
-
bug7158712.java
: Test results: passed: 1
-
- Pipeline: All checks have passed
- Testing Machine: SAP nightlies
SKIPPED
on2024-04-28
- Automated jtreg test: jtreg_jdk_tier4
-
javax/swing/plaf/synth/7158712/bug7158712.java
:SKIPPED
[Filter: jtregExcludeListFilter - Test has been excluded by an exclude list] GitHub 📊 - [0 msec]
Progress
- [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [x] JDK-8253980 needs maintainer approval
Issue
- JDK-8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows (Bug - P4 - Approved)
Reviewers
- Matthias Baesken (@MBaesken - Reviewer)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2688/head:pull/2688
$ git checkout pull/2688
Update a local copy of the PR:
$ git checkout pull/2688
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2688/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2688
View PR using the GUI difftool:
$ git pr show -t 2688
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2688.diff
Webrev
:wave: Welcome back ashi! A progress list of the required criteria for merging this PR into master
will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@amosshi This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows
Reviewed-by: mbaesken
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 16 new commits pushed to the master
branch:
- b7822c39d323e470ea63289cf72c6a5ec43e6107: 8331643: [11u]: Bump GHA bootstrap JDK to 11.0.23
- 3f636f30f9f040a8d320a4be7c2122fb22fd00bf: 8310818: Refactor more Locale tests to use JUnit
- 1da8fd845cbed721ecc418d44573dd66743b639c: 8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer
- cabaf7482681fb17cb7722377da6baab0ed2fed3: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"
- 137a8b9dcfaad4a96dfd22f57c759dfc4ea71f05: 8308021: Update IANA Language Subtag Registry to Version 2023-05-11
- d42634bdacb1b98cf3740f0fc73562385661f6ef: 8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path
- 93630950c24d4e9c30507484aeecc91b6b57a584: 8328194: Add a test to check default rendering engine
- 81f2413af5207fd52e23d26e33bc73dca96649a2: 8318809: java/util/concurrent/ConcurrentLinkedQueue/WhiteBox.java shows intermittent failures on linux ppc64le and aarch64
- f7d05223d21bd8f4d2dda7546d72b17d069d5304: 8315889: Open source several Swing HTMLDocument related tests
- 1e1688a32a537e18276dc208c03b8e6f30f70fe9: 8294137: Review running times of java.math tests
- ... and 6 more: https://git.openjdk.org/jdk11u-dev/compare/dabf4d16a190f5169a2eb56ff964f9a3365bce62...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master
branch, type /integrate in a new comment.
This backport pull request has now been updated with issue from the original commit.
⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
/approval request "Backporting for parity with 11.0.24-oracle. Un-Clean backport. No risk, test fix. SAP nightlies SKIPPED on 2024-04-28. Tested passed in local machine on both Windows 11 and MacOS 14.4.1”
@amosshi 8253980: The approval request has been created successfully.
/integrate
Going to push as commit 6b225d5a632496431550ebd31379660384fc2eaf.
Since your change was applied there have been 19 commits pushed to the master
branch:
- b9cb5721c999093aaf8e40677e2bac919dab879e: 8313702: Update IANA Language Subtag Registry to Version 2023-08-02
- c542dc913a765e9f7ab3ab47d51d5633f8716b9b: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket
- 4202063c1b663cd0ed16209d54b257faf637cd08: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException
- b7822c39d323e470ea63289cf72c6a5ec43e6107: 8331643: [11u]: Bump GHA bootstrap JDK to 11.0.23
- 3f636f30f9f040a8d320a4be7c2122fb22fd00bf: 8310818: Refactor more Locale tests to use JUnit
- 1da8fd845cbed721ecc418d44573dd66743b639c: 8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer
- cabaf7482681fb17cb7722377da6baab0ed2fed3: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"
- 137a8b9dcfaad4a96dfd22f57c759dfc4ea71f05: 8308021: Update IANA Language Subtag Registry to Version 2023-05-11
- d42634bdacb1b98cf3740f0fc73562385661f6ef: 8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path
- 93630950c24d4e9c30507484aeecc91b6b57a584: 8328194: Add a test to check default rendering engine
- ... and 9 more: https://git.openjdk.org/jdk11u-dev/compare/dabf4d16a190f5169a2eb56ff964f9a3365bce62...master
Your commit was automatically rebased without conflicts.
@amosshi Pushed as commit 6b225d5a632496431550ebd31379660384fc2eaf.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.