jdk11u-dev
jdk11u-dev copied to clipboard
8223737: HostsFileNameService doesn't handle IPv6 literal addresses correctly
Backport of JDK-8223737, dependency of JDK-8314517
Testing
- Local: Test passed on
MacOS 14.4.1
-
InternalNameServiceWithHostsFileTest.java
: Test results: passed: 1
-
- Pipeline: All checks have passed
- Testing Machine: SAP nightlies passed on
2024-04-27
- Automated jtreg test: jtreg_jdk_tier2
-
java/net/InetAddress/InternalNameServiceWithHostsFileTest.java
: SUCCESSFUL GitHub 📊⏲ - [2,513 msec]
Progress
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8223737 needs maintainer approval
Issue
- JDK-8223737: HostsFileNameService doesn't handle IPv6 literal addresses correctly (Sub-task - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2683/head:pull/2683
$ git checkout pull/2683
Update a local copy of the PR:
$ git checkout pull/2683
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2683/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2683
View PR using the GUI difftool:
$ git pr show -t 2683
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2683.diff
Webrev
:wave: Welcome back ashi! A progress list of the required criteria for merging this PR into master
will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
This backport pull request has now been updated with issue from the original commit.
⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
/approval request "Clean backport. SAP nightlies passed on 2024-04-27. Tested passed in local machine MacOS 14.4.1”
@amosshi 8223737: The approval request has been created successfully.
@amosshi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
This PR is for JDK-8223737, which is a real JDK code change It is the dependency of JDK-8314517, which is a test case backport
So add this real JDK change to OpenJDK 11 for a test case is not a good idea, if the JDK-8223737 itself is not required.
We will close this PR.