jdk11u-dev
jdk11u-dev copied to clipboard
openjdk
8329348: jdk11u build for Windows AArch64 fails
The root cause of the build error 'No rule to make target .../windows/conf/tzmappings' when building jdk11u for Windows AArch64 is that the GENSRC_TARGETS have not been built. This happens because the buildjdk is x86 but the target jdk is aarch64. Reusing artifacts is not correct in this scenario. The fix is to ensure that the required targets are built unconditionally for Windows AArch64.
Note that the existing checks for CREATING_BUILDJDK were also found to be incorrect in https://bugs.openjdk.org/browse/JDK-8217739
Builds on macOS, Linux, and Windows across both x64/AArch64 succeeded with this fix.
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8329348 needs maintainer approval
Issue
- JDK-8329348: jdk11u build for Windows AArch64 fails (Bug - P1)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2668/head:pull/2668
$ git checkout pull/2668
Update a local copy of the PR:
$ git checkout pull/2668
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2668/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2668
View PR using the GUI difftool:
$ git pr show -t 2668
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2668.diff
Webrev
:wave: Welcome back swesonga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
@swesonga This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@swesonga This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.
Hi @MBaesken, I am searching for a reviewer for this PR and I noticed that you reviewed one of the recent changes to this file. Would you be able to review this change or to suggest other possible reviewers?
lines 114-116 please check the indentation I think this has to be adjusted by one space. I am wondering how it works/worked for other cross builds then windows cross, the problem you describe sounds like it should be seen for cross builds on other platforms too?
I do not see Windows aarch in the list of supported builds for jdk11 https://wiki.openjdk.org/display/Build/Supported+Build+Platforms so is this really worth the effort for such an old release ?
I do not see Windows aarch in the list of supported builds for jdk11 https://wiki.openjdk.org/display/Build/Supported+Build+Platforms so is this really worth the effort for such an old release ?
Windows AArch64 is a supported platform for jdk11u. Microsoft backported this support in https://github.com/openjdk/jdk11u-dev/pull/301 We are looking into updating the supported build platforms page to reflect this.
lines 114-116 please check the indentation I think this has to be adjusted by one space. I am wondering how it works/worked for other cross builds then windows cross, the problem you describe sounds like it should be seen for cross builds on other platforms too?
Let me investigate cross builds on other platforms to verify the build behavior.
@swesonga This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@swesonga This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.