jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"

Open sendaoYan opened this issue 10 months ago • 6 comments

Hi,

Backport of JDK-8321925.

The origin PR use int nextInt(int origin, int bound) link , but the jdk11 do not have this API. So I change int nextInt(int origin, int bound) to nextInt(bound - origin) + origin link.

Only change the testcase, the change has been verified, the risk is low.

image

Thanks, -sendao


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] JDK-8321925 needs maintainer approval
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2631/head:pull/2631
$ git checkout pull/2631

Update a local copy of the PR:
$ git checkout pull/2631
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2631/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2631

View PR using the GUI difftool:
$ git pr show -t 2631

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2631.diff

Webrev

Link to Webrev Comment

sendaoYan avatar Mar 28 '24 03:03 sendaoYan

:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Mar 28 '24 03:03 bridgekeeper[bot]

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 4714685d6e4bfda3573ae82fa4bfc687460f4b75: 8328825: Google CAInterop test failures

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar Mar 28 '24 03:03 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Mar 28 '24 03:03 openjdk[bot]

Webrevs

mlbridge[bot] avatar Mar 28 '24 03:03 mlbridge[bot]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Apr 25 '24 05:04 bridgekeeper[bot]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Hi, can anyone review this PR. thanks.

Backport of JDK-8321925. Only change the testcase, the change has been verified, the risk is low.

sendaoYan avatar Apr 25 '24 06:04 sendaoYan

Hi, can anyone review this PR. thanks.

Backport of JDK-8321925. Only change the testcase, the change has been verified, the risk is low.

sendaoYan avatar May 13 '24 09:05 sendaoYan

LGTM.

Thanks for the review.

sendaoYan avatar May 14 '24 02:05 sendaoYan

/integrate

sendaoYan avatar May 14 '24 02:05 sendaoYan

@sendaoYan Your change (at version 548f51d80d8ab19423efdc68f17f1f712682dfe6) is now ready to be sponsored by a Committer.

openjdk[bot] avatar May 14 '24 02:05 openjdk[bot]

/sponsor

TheRealMDoerr avatar May 14 '24 08:05 TheRealMDoerr

Going to push as commit 270f3cfb3da7ef15e5fbbc3ea1d0d7cd3e3cf802. Since your change was applied there has been 1 commit pushed to the master branch:

  • 4714685d6e4bfda3573ae82fa4bfc687460f4b75: 8328825: Google CAInterop test failures

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar May 14 '24 08:05 openjdk[bot]

@TheRealMDoerr @sendaoYan Pushed as commit 270f3cfb3da7ef15e5fbbc3ea1d0d7cd3e3cf802.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar May 14 '24 08:05 openjdk[bot]

/sponsor

Thanks.

sendaoYan avatar May 14 '24 08:05 sendaoYan