jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8306408: Fix the format of several tables in building.md

Open zzambers opened this issue 1 year ago • 8 comments

Backport fixing several tables in doc/building.md, so they would display correctly in GitHub. Changes to doc/building.html were done manually, as there are some differences to table contents. Also table in Oracle Solaris Studio section was fixed, which is missing in newer jdks.

File doc/building.html was regenerated (pandoc used was one created by current jdk17u devkit, as this one seems to have be used previously -> no unrelated format changes).

Interestingly update of doc/building.html also removed one paragraph (about C99 standard). However, it turns out, this was accidentally included in JDK-8226910 backport to jdk11u-dev. Paragraph is from JDK-8224087, which has not been backported to jdk11u-dev. (So paragraph should never been there in first place.)


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [ ] JDK-8306408 needs maintainer approval
  • [x] Commit message must refer to an issue

Issue

  • JDK-8306408: Fix the format of several tables in building.md (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2533/head:pull/2533
$ git checkout pull/2533

Update a local copy of the PR:
$ git checkout pull/2533
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2533/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2533

View PR using the GUI difftool:
$ git pr show -t 2533

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2533.diff

Webrev

Link to Webrev Comment

zzambers avatar Feb 20 '24 15:02 zzambers

:wave: Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Feb 20 '24 15:02 bridgekeeper[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Feb 20 '24 15:02 openjdk[bot]

Webrevs

mlbridge[bot] avatar Feb 20 '24 15:02 mlbridge[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Mar 13 '24 19:03 openjdk[bot]

@zzambers This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Apr 11 '24 08:04 bridgekeeper[bot]

@zzambers This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar May 09 '24 11:05 bridgekeeper[bot]

/open

zzambers avatar Sep 02 '24 16:09 zzambers

@zzambers This pull request is now open

openjdk[bot] avatar Sep 02 '24 16:09 openjdk[bot]

@zzambers This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Sep 30 '24 17:09 bridgekeeper[bot]