8308593: Add KEEPALIVE Extended Socket Options Support for Windows

[tkyc]

This is an unclean backport of JDK-8308593, which provides support for the keepalive extended socket options on Windows.

The following changes are the differences from the original patch in order to get this backport working for 11u:

make/lib/Lib-jdk.net.gmk -- Updated this script to support building extnet for Windows.

src/jdk.net/share/classes/jdk/net/ExtendedSocketOptions.java -- Added a case to support returning an instance of WindowsSocketOptions in PlatformSocketOptions.

src/java.base/windows/classes/java/net/PlainSocketImpl.java -- The Windows PlainSocketImpl class will need to have similar setOption/getOption methods as the Unix PlainSocketImpl class to support setting these extended socket options for Windows.

Backport passed against Tier 1 tests and was manually verified to be working on Windows.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] JDK-8308593 needs maintainer approval

Issue

• JDK-8308593: Add KEEPALIVE Extended Socket Options Support for Windows (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2278/head:pull/2278
$ git checkout pull/2278

Update a local copy of the PR:
$ git checkout pull/2278
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2278/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2278

View PR using the GUI difftool:
$ git pr show -t 2278

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2278.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back tkyc! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

This backport pull request has now been updated with issue from the original commit.

[tkyc]

/approval request Requesting backport approval to 11u to have keepalive parity with the other OS platforms. Risk is low as the new code path in the backported code applies to Windows only and requires the new socket options to be set to take effect. Backport was ran against Tier 1 tests and was also manually tested. There's also existing tests in 11u that cover this scenario and so no new tests were added.

[openjdk[bot]]

@tkyc 8308593: The approval request has been created successfully.

[mlbridge[bot]]

Webrevs

• 00: Full (8322944b)

[GoeLin]

Hi @tkyc, please only label for approval if you have a review, i.e. the change is ready to be integrated. Did you make sure all relevant tests did run? Tier1 is only a basic sanity check.

[tkyc]

@GoeLin apologies, my mistake. Aside from tier 1, I ran the keepalive tests from PR JDK-8194298 that initially added support for Linux (which passed). At the moment also I'm running the jdk_net test group as well just as another precaution. Let me know if there's any further testing I can do.

[tkyc]

An update, my jdk_net test group run also passed.

[tkyc]

Hello, let me know if there's anything else I can do to move this forward.

[bridgekeeper[bot]]

@tkyc This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[tkyc]

Hello, just bumping the thread. Let me know if there's anything I can do to progress this towards integration. I'll check back in the new year as right now I'm on vacation.

[bridgekeeper[bot]]

@tkyc This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[tkyc]

Let me know how I can progress this towards integration. Thanks.

[bridgekeeper[bot]]

@tkyc This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[openjdk[bot]]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

[tkyc]

Let me know how I can progress this towards integration. Thanks.

[bridgekeeper[bot]]

@tkyc This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[tkyc]

Commenting for activity. Let me know how I can progress this towards integration. Thanks.

[bridgekeeper[bot]]

@tkyc This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@tkyc This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.