jdk icon indicating copy to clipboard operation
jdk copied to clipboard

7175396: The text on label is not painted red for Nimbus LaF.

Open prsadhuk opened this issue 3 years ago • 5 comments

Label.foreground UIProperty is not honored by Nimbus L&F. Added support for setting JLabel foreground color for Nimbus L&F


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-7175396: The text on label is not painted red for Nimbus LaF.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9900/head:pull/9900
$ git checkout pull/9900

Update a local copy of the PR:
$ git checkout pull/9900
$ git pull https://git.openjdk.org/jdk pull/9900/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9900

View PR using the GUI difftool:
$ git pr show -t 9900

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9900.diff

prsadhuk avatar Aug 17 '22 10:08 prsadhuk

:wave: Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Aug 17 '22 10:08 bridgekeeper[bot]

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Aug 17 '22 10:08 openjdk[bot]

Updated fix looks good.

honkar-jdk avatar Sep 23 '22 17:09 honkar-jdk

It would be good to understand how all that properties are handled by the skin. For example can you please check how the next property in the NimbusDefaults.java is handled by the L&F. addColor(d, "Label[Disabled].textForeground", "nimbusDisabledText", 0.0f, 0.0f, 0.0f, 0); Does it works fine? If yes probably we should add something like addColor(d, "Label[Enabled].textForeground", "nimbusDisabledText", 0.0f, 0.0f, 0.0f, 0); ?

mrserb avatar Oct 12 '22 21:10 mrserb

@prsadhuk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Nov 09 '22 21:11 bridgekeeper[bot]

@prsadhuk This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Dec 07 '22 23:12 bridgekeeper[bot]

/open

prsadhuk avatar Dec 09 '22 16:12 prsadhuk

@prsadhuk This pull request is now open

openjdk[bot] avatar Dec 09 '22 16:12 openjdk[bot]

Carried forward in https://github.com/openjdk/jdk/pull/11660

prsadhuk avatar Dec 14 '22 05:12 prsadhuk