jdk
jdk copied to clipboard
[PATCH] Use try-with-resources in X11FontManager.registerFontDir
Makes code easier to read.
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [ ] Commit message must refer to an issue
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9879/head:pull/9879
$ git checkout pull/9879
Update a local copy of the PR:
$ git checkout pull/9879
$ git pull https://git.openjdk.org/jdk pull/9879/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9879
View PR using the GUI difftool:
$ git pr show -t 9879
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9879.diff
:wave: Welcome back aturbanov! A progress list of the required criteria for merging this PR into master
will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@turbanoff The following label will be automatically applied to this pull request:
-
client
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
@turbanoff This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8293159: Use try-with-resources in X11FontManager.registerFontDir
Reviewed-by: prr
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 215 new commits pushed to the master
branch:
- fa68371bb816d797da02e51187955044f835d402: 8292584: assert(cb != __null) failed: must be with -XX:-Inline
- 04d8069bacc6259fc5bf9de6963bb099fcfc4961: 8230374: maxOutputSize, instead of javatest.maxOutputSize, should be used in TEST.properties
- 3d254d3c8ea7f409e8f709413f80d88913eb0ce8: 8289510: Improve test coverage for XPath Axes: namespace
- 2d18dda3f2074a4f8b9a0c62ece9ac6d5284e93b: 8173605: Remove support for source and target 1.7 option in javac
- 7c2f2994da1577152870eaf2ea71dfba470c29ef: 8293202: Document how to edit doc/testing, doc/building
- 07616de00c3e1c305852fcc44df8dadafd0dbf3f: 8175382: clhsdb pmap should print the end addresses of the load modules
- 9444a081cc9873caa7b5c6a78df0d1aecda6e4f1: 8290709: Incorrect dominance error for unconditional pattern vs. null
- 6a1b0b5649dd4f2a970df0839bf77bdb899fbd6f: 8293154: TemporalQueries java doc error
- 5204528296a53d7dc77e67b26be23a64692527fa: 8293201: Library detection in runtime/ErrorHandling/TestDwarf.java fails on some systems
- 2d10d4f54ebd9d46f70a18695bf60f30dda92522: 8291651: CleanerTest.java fails with "Cleanable was cleaned"
- ... and 205 more: https://git.openjdk.org/jdk/compare/695bb3939135394a4627d1c41cfc30d11b19bf48...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master
branch, type /integrate in a new comment.
/integrate
Going to push as commit ef20ffe4d222d48f0bdba81a0b864d9fb455e9a6.
Since your change was applied there have been 258 commits pushed to the master
branch:
- 056ed48ddaa9378793616cf966501cc9536f336a: 8293180: JQuery UI license file not updated
- dbb2c4b6ac01d2a3367a2354213d3b4230dfbb96: 8288897: Clean up node dump code
- 9833c025fd7daf6bb1be81d93148a4204a9f184c: 8292946: GC lock/jni/jnilock001 test failed "assert(gch->gc_cause() == GCCause::_scavenge_alot || !gch->incremental_collection_failed()) failed: Twice in a row"
- d7536588b38e368eaa6395bcbcc6724a39303fc5: 8293107: GHA: Bump to Ubuntu 22.04
- d4e3e69505db1b114afec2f6a61acf1261a8e69c: 8293344: JDK-8242181 broke stack printing for non-attached threads
- 2c61efe3de9095631077aaf67edd2695edac6259: 8282648: Weaken the InflaterInputStream specification in order to allow faster Zip implementations
- e31c537f0583261ac326cb74fd90c155629e1b50: 8293224: Add link to openjdk.org/jtreg/ from doc/testing
- 955baa3c44805538df5f95ccc91d2d5a08c85b81: 8267374: macOS: Option+Up/Down Arrow don't traverse to beginning/end of line in JTextArea
- 8df671c908d10b586540cc916a91e083c6098648: 8293355: JDK-8293167 included bad copyright header
- 5bed9f767507bb0f123247d149ead84d2d635f52: 8293290: RISC-V: Explicitly pass a third temp register to MacroAssembler::store_heap_oop
- ... and 248 more: https://git.openjdk.org/jdk/compare/695bb3939135394a4627d1c41cfc30d11b19bf48...master
Your commit was automatically rebased without conflicts.
@turbanoff Pushed as commit ef20ffe4d222d48f0bdba81a0b864d9fb455e9a6.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.