8292314: WINAPI address used as conditional in libsplashscreen

[TheShermanTanker]

libsplashscreen uses the address of the WINAPI UpdateLayeredWindow in the condition of an if block, which will always evaluate to true since the address is never NULL. It is highly unlikely that this is intentional, and is either a harmless mistake that is ultimately optimized out during compilation at best, or an as of yet uncaught, but severe bug in the implementation that fails to call UpdateLayeredWindow at worst.

Note: As of now the change simply removes the reference, advice is appreciated if the commit is incorrect and the affected site is actually meant to be a call to UpdateLayeredWindow (as well as whatever parameters are required)

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8292314: WINAPI address used as conditional in libsplashscreen

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9866/head:pull/9866
$ git checkout pull/9866

Update a local copy of the PR:
$ git checkout pull/9866
$ git pull https://git.openjdk.org/jdk pull/9866/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9866

View PR using the GUI difftool:
$ git pr show -t 9866

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9866.diff

[bridgekeeper[bot]]

:wave: Welcome back jwaters! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@TheShermanTanker The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 02: Full - Incremental (3082cae2)
• 01: Full - Incremental (3e7830d7)
• 00: Full (e528093d)

[openjdk[bot]]

@TheShermanTanker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292314: Cleanup legacy address handling

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[TheShermanTanker]

I see, will change the issue to reflect that before integrating

[TheShermanTanker]

/integrate

[openjdk[bot]]

@TheShermanTanker Your change (at version e528093d970147597533a2dad021d5fb786bf6d2) is now ready to be sponsored by a Committer.

[TheShermanTanker]

/integrate

[openjdk[bot]]

@TheShermanTanker Your change (at version 3e7830d703fdb138cc37c1c8aafc8a713c5cd824) is now ready to be sponsored by a Committer.

[TheShermanTanker]

/integrate

[openjdk[bot]]

@TheShermanTanker Your change (at version 3082cae26cfd9db369cfc31c5ee5971b9e761520) is now ready to be sponsored by a Committer.

[prrace]

/sponsor

[openjdk[bot]]

Going to push as commit 95a33fe1502b6f0db2c60fa92b389fda74d94407. Since your change was applied there have been 56 commits pushed to the master branch:

• 5d799d80e638b85fa3881904e7330ffb5100764a: 8292304: [REDO] JDK-8289208 Test DrawRotatedStringUsingRotatedFont.java occasionally crashes on MacOS
• 4f50316a1a985cd06af7eed158d7e1917b86d159: 8292680: Convert Dictionary to ConcurrentHashTable
• 2fe0ce01485d7b84dc109d3d4f24bdd908c0e7cf: 8292203: AArch64: Represent Registers as values
• 251bff6beeafcd98824dab60e9831c0175fe0689: 8292877: java/util/concurrent/atomic/Serial.java uses {Double,Long}Accumulator incorrectly
• f57d34242c9b47936d137589fc75ab794d39a9d1: 8292867: RISC-V: Simplify weak CAS return value handling
• 88af204027ec51d6e13516fa61e1c217a9445c62: 8292494: Ensure SystemDictionary::set_platform_loader and set_system_loader are called only once
• 8d3d4397ccbfadab99fe572f0d0a8504d268a0dc: 8292903: enhance round_up_power_of_2 assertion output
• 054c23f484522881a0879176383d970a8de41201: 8290025: Remove the Sweeper
• dc7e2562f47edb1489f2fb0c8d6ec847fb7a6dc5: 8290376: G1: Refactor G1MMUTracker::when_sec
• 5a20bc44b1fb4edb6ab714191cdc6c3f33ac9836: 8292715: Cleanup Problemlist
• ... and 46 more: https://git.openjdk.org/jdk/compare/a17fce7507c7d485d51f98fadd444235ea31058d...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@prrace @TheShermanTanker Pushed as commit 95a33fe1502b6f0db2c60fa92b389fda74d94407.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.