jdk
jdk copied to clipboard
8292280: Unused field 'keyListener' in BasicRadioButtonUI
Field keyListener
was added under JDK-8033699. But then all its usages were removed in JDK-8249548
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8292280: Unused field 'keyListener' in BasicRadioButtonUI
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9832/head:pull/9832
$ git checkout pull/9832
Update a local copy of the PR:
$ git checkout pull/9832
$ git pull https://git.openjdk.org/jdk pull/9832/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9832
View PR using the GUI difftool:
$ git pr show -t 9832
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9832.diff
:wave: Welcome back aturbanov! A progress list of the required criteria for merging this PR into master
will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@turbanoff The following label will be automatically applied to this pull request:
-
client
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@turbanoff This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8292280: Unused field 'keyListener' in BasicRadioButtonUI
Reviewed-by: jdv, serb
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 670 new commits pushed to the master
branch:
- d4c9a88073479ff05e6c07ed599c546826d6f6ba: 6560981: (cal) unused local variables in GregorianCalendar, etc.
- 5dd851d872c50ef33034c56007c58e6fa69ebd32: 8281453: New optimization: convert ~x into -1-x when ~x is used in an arithmetic expression
- 85569e966c22e5b5314a157d05c43c0f6e8c2b28: 8286037: Bump minimum boot jdk to JDK 19
- fef345b19f74f5d706b173b1af87bcda98dc6ff2: 8293672: Update freetype md file
- 5c030cccae6cd7862b7ecc563fde4b7670f25c10: 8290973: In AffineTransform, equals(Object) is inconsistent with hashCode()
- f888aa953c1335f438ded22abf66b090e894684c: 8293061: Combine CDSOptions and AppCDSOptions test utility classes
- 73f06468ae7f9eebb8e37f2a534d2c19a8dac60d: 8294839: Disable StressLongCountedLoop in compiler/loopopts/TestRemoveEmptyLoop.java
- 2ceebf681ffd6f9bf6967fd81b30d721bc010b94: 8294456: Fix misleading-indentation warnings in core JDK libraries
- ad7b7d40ce7b71d9e1e13e1b92f3ca6b30e635a2: 8294697: java/lang/Thread/virtual/ThreadAPI.testGetStackTrace2 failed with non-empty stack trace
- e38ae8a6510c8a83d65f8f39c276a0ad7572e26d: 8294759: Print actual lock/monitor ranking
- ... and 660 more: https://git.openjdk.org/jdk/compare/ad5f628c58c46438f2f542d5255e5fd1fa4d0c6b...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master
branch, type /integrate in a new comment.
/integrate
Going to push as commit 2d25c0a31c608ecddaa084d795a060598b3e0589.
Since your change was applied there have been 674 commits pushed to the master
branch:
- 0ad6803ac2bba063d15ce8284a09da36b4cced81: 8293810: Remove granting of RuntimePermission("stopThread") from tests
- cf84c8eaf265255b49293650b3919f22e26d48a3: 8292975: javac produces code that crashes with LambdaConversionException
- f3a44a48359a4390b13549ce70de3a04710a1d21: 8075916: The regression-swing case failed as colored text is not shown on disabled checkbox and radio button with Nimbus LAF
- 37bd4fbe3031fd7793ab947e7f58aefd9c021c44: 6852577: Only for Nimbus LAF UIManager.get("PasswordField.echoChar") is null
- d4c9a88073479ff05e6c07ed599c546826d6f6ba: 6560981: (cal) unused local variables in GregorianCalendar, etc.
- 5dd851d872c50ef33034c56007c58e6fa69ebd32: 8281453: New optimization: convert ~x into -1-x when ~x is used in an arithmetic expression
- 85569e966c22e5b5314a157d05c43c0f6e8c2b28: 8286037: Bump minimum boot jdk to JDK 19
- fef345b19f74f5d706b173b1af87bcda98dc6ff2: 8293672: Update freetype md file
- 5c030cccae6cd7862b7ecc563fde4b7670f25c10: 8290973: In AffineTransform, equals(Object) is inconsistent with hashCode()
- f888aa953c1335f438ded22abf66b090e894684c: 8293061: Combine CDSOptions and AppCDSOptions test utility classes
- ... and 664 more: https://git.openjdk.org/jdk/compare/ad5f628c58c46438f2f542d5255e5fd1fa4d0c6b...master
Your commit was automatically rebased without conflicts.
@turbanoff Pushed as commit 2d25c0a31c608ecddaa084d795a060598b3e0589.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.