jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8133816: Display server side enabled ciphersuites for debug mode

Open weibxiao opened this issue 2 years ago • 4 comments

Log the debugging info for server cipher suites when setting javax.net.debug == ssl, handshake.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8133816: Display server side enabled ciphersuites for debug mode

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9731/head:pull/9731
$ git checkout pull/9731

Update a local copy of the PR:
$ git checkout pull/9731
$ git pull https://git.openjdk.org/jdk pull/9731/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9731

View PR using the GUI difftool:
$ git pr show -t 9731

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9731.diff

weibxiao avatar Aug 03 '22 15:08 weibxiao

:wave: Welcome back weibxiao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Aug 03 '22 15:08 bridgekeeper[bot]

@weibxiao The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Aug 03 '22 15:08 openjdk[bot]

⚠️ @weibxiao This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

openjdk[bot] avatar Aug 04 '22 18:08 openjdk[bot]

The build and test for Oracle Mach5 were passed.

weibxiao avatar Aug 08 '22 00:08 weibxiao

Webrevs

mlbridge[bot] avatar Aug 17 '22 12:08 mlbridge[bot]

This change will let the developer know the configuration of the server socket when the errors happen through debugging enabled.

  1. Updated the code format, the case of log messages
  2. New boolean variable CSFound is removed by combining the error messages together
  3. Only enabled cipher suites of server socket will be printed out
  4. Still keep the list of the legacy suites since it is created during the process. It will only be printed out when it is available.

weibxiao avatar Aug 23 '22 15:08 weibxiao

@weibxiao This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Sep 26 '22 12:09 bridgekeeper[bot]

@weibxiao This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Oct 24 '22 20:10 bridgekeeper[bot]