jdk
jdk copied to clipboard
openjdk
TIFF plugin: JPEG compression and alpha channel is not supported
This is a followup on email thread: https://mail.openjdk.java.net/pipermail/client-libs-dev/2022-May/004882.html
The gist is that having transparency (alpha) in a JPEG compressed TIFF container is not supported. Unsupported Image Type exception used to be thrown before JDK-8274735 [openjdk/jdk/pull/7849] got integrated. Since then, the 4 components JPEG from such TIFF file is erroneously interpreted as CMYK, while in fact it is an unsupported RGBA.
This commit makes the TIFFImageReader to throw a meaningful exception informing user that such combination of colour space and compression is not supported.
The accompanying test verifies that the exception is indeed thrown when expected.
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [ ] Commit message must refer to an issue
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8846/head:pull/8846
$ git checkout pull/8846
Update a local copy of the PR:
$ git checkout pull/8846
$ git pull https://git.openjdk.java.net/jdk pull/8846/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8846
View PR using the GUI difftool:
$ git pr show -t 8846
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8846.diff
:wave: Welcome back Karm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Karm The following label will be automatically applied to this pull request:
client
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
Hello @prrace, Is there anything specific I could do for this PR?
Thx for guidance.
@Karm This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Hello, I would still like this PR to be included as it prevents a silent misinterpretation of data in TIFF plugin.
Are there any changes you'd like me to do, @prrace?
@Karm This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@Karm This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
LGTM. I'm not qualified to comment on the test code, but the new error presents a useful message. The method already throws an IIOException, so no problems there. You'll need a JBS issue for this to continue, but I don't have access to it yet either. I'm sorry this PR has been stuck in limbo.
@Karm This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
I don't have reviewer permissions, and I don't think I ever will. They do not want pseudonymous developers, and I want my privacy.
Hello @jaikiran, give them an inch and they'll take a mile, as they say.
With @prrace being otherwise engaged, would you happen to be knowledgeable enough about client libs, namely graphics formats encoders/decoders to set up this PR for a review too?
Cheers K.
Hello @jaikiran, give them an inch and they'll take a mile, as they say. With @prrace being otherwise engaged, would you happen to be knowledgeable enough about
clientlibs, namely graphics formats encoders/decoders to set up this PR for a review too?Cheers K.
Hello @Karm, I don't have the knowledge of the client area of the JDK to provide any inputs on this proposed change. Phil is the right person.
It looks to me that this PR hasn't triggered an official review since this doesn't have a corresponding JBS issue created and linked to it. So that means that the discussion in this PR isn't being auto copied to the client-libs-dev mailing list. I don't know if Phil watches the github personal notifications. I think, wait for a day or two more and then check on the client-libs-dev team on their mailing list https://mail.openjdk.org/mailman/listinfo/client-libs-dev on how to proceed.
@Karm This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@Karm This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Adding comment...
I'd still like to see this through or get a feedback as to why it's not suitable.
@Karm Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.
@Karm This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@Karm This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@Karm This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@Karm This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!