8373246: JDK-8351842 broke native debugging on Linux

[RealCLanger]

This change adds back debug symbols by default to non-product builds.

Whether to add debug symbols to the images/bundles created in a build is controlled by the configure switch --with-external-symbols-in-bundles. Possible values are full, which will be the default setting for non-product builds, none which is the default for product builds and a special option public which is only supported on Windows and enables stripped debug files in JDK/JRE images and bundles that are smaller than full debug files but still allow function names to be displayed in, e.g. hs_err files.

If external-symbols-in-bundles are turned on, they propagate into images and bundles through the jmod files. With that, some code of Bundles.gmk that took care of copying the right set of debug files is now obsolete and can be removed.

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8373246: JDK-8351842 broke native debugging on Linux (Bug - P2)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28829/head:pull/28829
$ git checkout pull/28829

Update a local copy of the PR:
$ git checkout pull/28829
$ git pull https://git.openjdk.org/jdk.git pull/28829/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28829

View PR using the GUI difftool:
$ git pr show -t 28829

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28829.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373246: JDK-8351842 broke native debugging on Linux

Reviewed-by: erikj, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 78c2d57259ad829a2cfc1370efbb2a5913df4661: 8373668: Add override keyword to *Klass classes
• b1e8c4e030f42ea3146b2502c9ab030bc79a8147: 8372543: Shenandoah: undercalculated the available size when soft max takes effect
• 3f33eaa42aff45422c94300573c898868189fdfc: 8373649: Convert simple AtomicAccess usage in ConcurrentHashTable to use Atomic<T>
• ... and 7 more: https://git.openjdk.org/jdk/compare/34f241317ecd7473cfb6dcc2e6e5cf3a40299e2c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk[bot]]

@RealCLanger The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 00: Full (d4d75a38)

[RealCLanger]

Looks good also in our internal testing. Thanks for the reviews.

/integrate

[openjdk[bot]]

Going to push as commit b5ac8f83682ddb9623a1b43bd62f309b2961a504. Since your change was applied there have been 79 commits pushed to the master branch:

• 45642acf1b290306509375e58bde8f6c9cd1b308: 8373710: Improve jpackage error reporting
• 14c93b2afbf0135e872866c7f8468d9ce6df1e0d: 8373537: Migrate "test/jdk/com/sun/net/httpserver/" to null-safe "SimpleSSLContext" methods
• 53e77d21c2308daad7d4aecf05da56609ed0291c: 8373801: Adopt arraycopy OopCopyResult from the lworld branch
• ... and 76 more: https://git.openjdk.org/jdk/compare/34f241317ecd7473cfb6dcc2e6e5cf3a40299e2c...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@RealCLanger Pushed as commit b5ac8f83682ddb9623a1b43bd62f309b2961a504.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.