jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8355953: Add unit testing for internal jrtfs class prior to Valhalla work

Open david-beaumont opened this issue 7 months ago • 4 comments

<draft PR for early feedback - do not review in depth yet unless asked>

This adds initial unit tests for the ExplodedImage class, but the aim is to make the helper able to create JImage images too, and then have tested run with both to show same behaviour.

I am going to be changing these classes soon(ish) as part of valhalla work, so having test coverage in mainline now is useful when refactoring later.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8355953: Add unit testing for internal jrtfs class prior to Valhalla work (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24962/head:pull/24962
$ git checkout pull/24962

Update a local copy of the PR:
$ git checkout pull/24962
$ git pull https://git.openjdk.org/jdk.git pull/24962/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24962

View PR using the GUI difftool:
$ git pr show -t 24962

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24962.diff

david-beaumont avatar Apr 30 '25 12:04 david-beaumont

:wave: Welcome back david-beaumont! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Apr 30 '25 12:04 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Apr 30 '25 12:04 openjdk[bot]

@david-beaumont The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Apr 30 '25 12:04 openjdk[bot]

@david-beaumont This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jun 26 '25 01:06 bridgekeeper[bot]