jdk icon indicating copy to clipboard operation
jdk copied to clipboard
verified publisher icon openjdk

8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree

Open fguallini opened this issue 1 year ago • 4 comments

The test sun/security/pkcs11/Provider/RequiredMechCheck.java extends sun/security/pkcs11/PKCS11Test.java, which sets up a PKCS11Provider configured with NSS config files located in the source tree directory (sun/security/pkcs11/nss) for the dependent tests to run properly. This test currently fails if that pkcs11/nss directory is made read-only because these config files are updated during the test execution. Files located in the source tree should not be modified when running tests. This PR updates the PKCS11Test to copy the NSS config files to the Jtreg scratch directory and configures the provider to use those files instead.

Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21665/head:pull/21665
$ git checkout pull/21665

Update a local copy of the PR:
$ git checkout pull/21665
$ git pull https://git.openjdk.org/jdk.git pull/21665/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21665

View PR using the GUI difftool:
$ git pr show -t 21665

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21665.diff

Webrev

Link to Webrev Comment

fguallini avatar Oct 23 '24 14:10 fguallini

:wave: Welcome back fguallini! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Oct 23 '24 14:10 bridgekeeper[bot]

@fguallini This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree

Reviewed-by: rhalade, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 205 new commits pushed to the master branch:

  • 6811a11e278118b8b2781f1eaf45d363a3d2db49: 8341408: Implement JEP 488: Primitive Types in Patterns, instanceof, and switch (Second Preview)
  • 72a45ddbad9c343200197348ccfcf74105e6fefa: 8341834: C2 compilation fails with "bad AD file" due to Replicate
  • 57c3bb6091f8ba0caced6f5ecf21dc998ffeee9f: 8343068: C2: CastX2P Ideal transformation not always applied
  • 83f3d42d6bcefac80449987f4d951f8280eeee3a: 8339303: C2: dead node after failing to match cloned address expression
  • ead0116f2624e0e34529e47e4f509142d588b994: 8331341: secondary_super_cache does not scale well: C1 and interpreter
  • 06d8216a4ef6b883119459da7e52b37d16cd2f03: 8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux
  • bdd68163df4d9b63694bfc0900e4b5ddb2475834: 8343502: RISC-V: SIGBUS in updateBytesCRC32 after JDK-8339738
  • 4431852a880b06241231d346311170331c20ab2d: 8342943: Replace predicate walking and cloning code for main/post loops with a predicate visitor
  • 1b0281dc77f41fc5df323c7f7b25a4138b1ffb9e: 8333427: langtools/tools/javac/newlines/NewLineTest.java is failing on Japanese Windows
  • 471f112bca715d04304cbe35c6ed63df8c7b7fee: 8342577: Clean up JVMTI breakpoint support
  • ... and 195 more: https://git.openjdk.org/jdk/compare/893266c48f26e089d0449d2c161b04430741970c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79, @rhalade) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar Oct 23 '24 14:10 openjdk[bot]

@fguallini The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Oct 23 '24 14:10 openjdk[bot]

Webrevs

mlbridge[bot] avatar Oct 23 '24 16:10 mlbridge[bot]

/integrate

fguallini avatar Nov 06 '24 16:11 fguallini

@fguallini Your change (at version 1b1eae9511a81edc8036adb8380a3ca95ab565b8) is now ready to be sponsored by a Committer.

openjdk[bot] avatar Nov 06 '24 16:11 openjdk[bot]

/sponsor

rhalade avatar Nov 06 '24 18:11 rhalade

Going to push as commit 342fe42555a0e892d21d187287ab996be199abb1. Since your change was applied there have been 208 commits pushed to the master branch:

  • 78b378ad03d0f6c85468ac208e84fabea79fc7de: 8342540: InterfaceCalls micro-benchmark gives misleading results
  • c0e6c3b93c0d21debc538e0135805c2957053108: 8343214: Fix encoding errors in APX New Data Destination Instructions Support
  • 0be7118b2f761b416ebf8cbb11473d51e80be409: 8279016: JFR Leak Profiler is broken with Shenandoah
  • 6811a11e278118b8b2781f1eaf45d363a3d2db49: 8341408: Implement JEP 488: Primitive Types in Patterns, instanceof, and switch (Second Preview)
  • 72a45ddbad9c343200197348ccfcf74105e6fefa: 8341834: C2 compilation fails with "bad AD file" due to Replicate
  • 57c3bb6091f8ba0caced6f5ecf21dc998ffeee9f: 8343068: C2: CastX2P Ideal transformation not always applied
  • 83f3d42d6bcefac80449987f4d951f8280eeee3a: 8339303: C2: dead node after failing to match cloned address expression
  • ead0116f2624e0e34529e47e4f509142d588b994: 8331341: secondary_super_cache does not scale well: C1 and interpreter
  • 06d8216a4ef6b883119459da7e52b37d16cd2f03: 8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux
  • bdd68163df4d9b63694bfc0900e4b5ddb2475834: 8343502: RISC-V: SIGBUS in updateBytesCRC32 after JDK-8339738
  • ... and 198 more: https://git.openjdk.org/jdk/compare/893266c48f26e089d0449d2c161b04430741970c...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Nov 06 '24 18:11 openjdk[bot]

@rhalade @fguallini Pushed as commit 342fe42555a0e892d21d187287ab996be199abb1.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Nov 06 '24 18:11 openjdk[bot]