jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8342884: RISC-V: verify float <--> float16 conversion

Open Hamlin-Li opened this issue 4 months ago • 4 comments

Hi, Can you help to review this simple patch? it removes the Experimental of the UseZvfh. Thanks

Currently, only float <--> float16 conversions use Zvfh extension, I've run the jmh tests on bananapi, the performance result shows it's good.

Benchmark-XX:+UseZfh -XX:+UnlockExperimentalVMOptions -XX:+/-UseZvfh (size) Mode Cnt Score -intrinsic Score +intrinsic Error Units Improvement
Fp16ConversionBenchmark.float16ToFloat 2048 avgt 10 8129.72 4729.125 71.937 ns/op 1.719
Fp16ConversionBenchmark.float16ToFloatMemory 2048 avgt 10 16.9 16.894 0.002 ns/op 1
Fp16ConversionBenchmark.floatToFloat16 2048 avgt 10 12561.962 3767.944 12.652 ns/op 3.334
Fp16ConversionBenchmark.floatToFloat16Memory 2048 avgt 10 18.146 18.147 0.003 ns/op 1

Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8342884: RISC-V: verify float <--> float16 conversion (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21664/head:pull/21664
$ git checkout pull/21664

Update a local copy of the PR:
$ git checkout pull/21664
$ git pull https://git.openjdk.org/jdk.git pull/21664/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21664

View PR using the GUI difftool:
$ git pr show -t 21664

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21664.diff

Webrev

Link to Webrev Comment

Hamlin-Li avatar Oct 23 '24 13:10 Hamlin-Li