jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8342807: Update links in java.base to use https://

Open eirbjo opened this issue 4 months ago • 7 comments

Please review this cleanup PR which updates a total of 12 links to external documentation or references in java.base to use https instead of plain text http.

Links in java.security and share/data/tzdata are excluded from this PR.

This is a documentaton-only cleanup. No tests are added or updated. noreg-cleanup added in the JBS. All updated links have been verified to resolve and to show the expected content.

There are two files here with non-Oracle copyright headers, not quite sure how to update those? (java_md_aix.h and xss-common-qsort.h).

Changes beyond the obvious are as follows:

linux/native/libsimdsort/xss-common-qsort.h: The current link uses a non-default port number. Changed to using the default port number. Reported upstream as intel/x86-simd-sort#170

share/man/keytool.1: www.oracle.com redirects this from /technetwork/java/javase/javasecarootcertsprogram-1876540.html to /java/technologies/javase/carootcertsprogram.html. Using the new URL here. Should this be updated in Oracle-internal sources as well?

unix/classes/sun/net/PortConfig.java The current link no longer resolves. As a replacement, I suggest https://www.ibm.com/support/pages/node/886227 which answers a support question regarding ephemeral ports.

unix/native/libjava/*, Links redirect from "www.opengroup.org" to "pubs.opengroup.org". Using this new host in the URLs

unix/native/libjava/ProcessImpl_md.c A link to pasc.org now requires authentication. I changed this to be a Wayback link. Alternantives would be to delete this link, or to track down a revised version of the spec the linked Interpretation Request refers to.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8342807: Update links in java.base to use https:// (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21633/head:pull/21633
$ git checkout pull/21633

Update a local copy of the PR:
$ git checkout pull/21633
$ git pull https://git.openjdk.org/jdk.git pull/21633/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21633

View PR using the GUI difftool:
$ git pr show -t 21633

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21633.diff

Webrev

Link to Webrev Comment

eirbjo avatar Oct 22 '24 10:10 eirbjo