jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8335977: Deoptimization fails with assert "object should be reallocated already"

Open JohnTortugo opened this issue 4 months ago • 5 comments

Please, review this patch to fix an issue that may occur when serializing debug information related to reduce allocation merges. The problem happens when there are more than one JVMS in a uncommon_trap and a younger JVMS doesn't have the RAM inputs as a local/expression/monitor but an older JVMS does. In that situation the loop at line 1173 of output.cpp will set the is_root property of the ObjectValue to false when processing the younger JVMS even though it may have been set to true when visiting the older JVMS.

Tested on:

  • Win, Mac & Linux tier1-4 on x64 & Aarch64.
  • CTW with some thousands of jars.

Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8335977: Deoptimization fails with assert "object should be reallocated already" (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21624/head:pull/21624
$ git checkout pull/21624

Update a local copy of the PR:
$ git checkout pull/21624
$ git pull https://git.openjdk.org/jdk.git pull/21624/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21624

View PR using the GUI difftool:
$ git pr show -t 21624

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21624.diff

Webrev

Link to Webrev Comment

JohnTortugo avatar Oct 21 '24 20:10 JohnTortugo