jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8342482: Use the same native thread initialization procedure on all platforms

Open dholmes-ora opened this issue 1 year ago • 4 comments

This fixes an issue reported in https://bugs.openjdk.org/browse/JDK-8340401 caused by a difference in the thread initialization protocol for new Java threads, by using the same Monitor-based "handshake" protocol on all platforms. This allows all the related code, including the _threadStart_lock to be put into the shared OSThreadBase class.

For AIX and Windows this means threads are no longer started in a suspended state.

Testing

  • GHA
  • Tiers 1-4

Thanks


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8342482: Use the same native thread initialization procedure on all platforms (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21558/head:pull/21558
$ git checkout pull/21558

Update a local copy of the PR:
$ git checkout pull/21558
$ git pull https://git.openjdk.org/jdk.git pull/21558/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21558

View PR using the GUI difftool:
$ git pr show -t 21558

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21558.diff

dholmes-ora avatar Oct 17 '24 07:10 dholmes-ora

:wave: Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Oct 17 '24 07:10 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Oct 17 '24 07:10 openjdk[bot]

@dholmes-ora The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Oct 17 '24 07:10 openjdk[bot]

@dholmes-ora this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8342482-thread-start
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

openjdk[bot] avatar Oct 22 '24 18:10 openjdk[bot]

@dholmes-ora This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Dec 12 '24 11:12 bridgekeeper[bot]

@dholmes-ora This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Feb 06 '25 14:02 bridgekeeper[bot]