jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8339289: Parameter size mismatch between client and VM sides of the Attach API - Windows

Open alexmenkov opened this issue 6 months ago • 10 comments

The fix improves Attch API protocol and implements updated protocol on windows; shared code is ready to implement updated protocol support on other platforms. More detailed explanations on the 1st comment.

Testing: tier1,tier2,tier3,tier4,hs-tier5-svc manually tested backward compatibility (old tools can attach to current VMs, current tools can attach to older VMs) on Windows with jdk21u and jdk8u.


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8339289: Parameter size mismatch between client and VM sides of the Attach API - Windows (Sub-task - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20782/head:pull/20782
$ git checkout pull/20782

Update a local copy of the PR:
$ git checkout pull/20782
$ git pull https://git.openjdk.org/jdk.git pull/20782/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20782

View PR using the GUI difftool:
$ git pr show -t 20782

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20782.diff

Webrev

Link to Webrev Comment

alexmenkov avatar Aug 30 '24 00:08 alexmenkov