8335623: Clean up HtmlTag.HtmlTag and make the ARIA role attribute global

[nizarbenalla]

trafficstars

Can I please get a review for this small change? It removes some lines that are no longer necessary and sets the ARIA role as global. Thanks in advance.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8335623: Clean up HtmlTag.HtmlTag and make the ARIA role attribute global (Bug - P4)

Reviewers

• Chen Liang (@liach - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20007/head:pull/20007
$ git checkout pull/20007

Update a local copy of the PR:
$ git checkout pull/20007
$ git pull https://git.openjdk.org/jdk.git pull/20007/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20007

View PR using the GUI difftool:
$ git pr show -t 20007

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20007.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back nbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@nizarbenalla This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335623: Clean up HtmlTag.HtmlTag and make the ARIA role attribute global

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 94 new commits pushed to the master branch:

• 9eb611e7f07ebb6eb0cbcca32d644abf8352c991: 8334055: Unhelpful 'required: reference' diagnostics after JDK-8043226
• 5100303c6c5e4224d2c41f90719139bb5f4e236e: 8335668: NumberFormat integer only parsing should throw exception for edge case
• 58c98420b65bcea08f37982fdfba747005c03553: 8336021: Doccheck: valign not allowed for HTML5 in java.xml
• d06d79c80980644df511cded0eb8bc0309d878d3: 8325369: @sealedGraph: Bad link to image for tag on nested classes
• dea92742c2b5889717f2183dc29b5772daff5340: 8332125: [nmt] Totals in diff report should print out total malloc and mmap diffs
• 5c612c230b0a852aed5fd36e58b82ebf2e1838af: 8332689: RISC-V: Use load instead of trampolines
• 6fcd49f9431cc3507f96ef2acdca43fc6a394a14: 8336239: Fix javadoc markup in java.lang.Process
• b32e4a68bca588d908bd81a398eb3171a6876dc5: 8335356: Shenandoah: Improve concurrent cleanup locking
• 62cbf70346e78ca94ce6ea4ba5a308ea0a2bbfa8: 8336085: Fix simple -Wzero-as-null-pointer-constant warnings in CDS code
• 2928753bd95356467e4fe42ee391e45d1cb6e89c: 8324966: Allow selecting jtreg test case by ID from make
• ... and 84 more: https://git.openjdk.org/jdk/compare/6c84e9c8cb71aac103901c0d92fe6ae51aabff15...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@liach) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk[bot]]

@nizarbenalla The following label will be automatically applied to this pull request:

• javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 00: Full (94c1ca84)

[nizarbenalla]

Congrats on becoming a reviewer

/integrate

[openjdk[bot]]

@nizarbenalla Your change (at version 94c1ca8429fee2da0a9b2da1ce208bed371c2e0d) is now ready to be sponsored by a Committer.

[liach]

Thank you for your consistent improvement fixes!

/sponsor

[openjdk[bot]]

Going to push as commit 889055713ea83f899ebd7bf640dcf3c3e1a82ebe. Since your change was applied there have been 95 commits pushed to the master branch:

• 73e3e0edeb20c6f701b213423476f92fb05dd262: 8321509: False positive in get_trampoline fast path causes crash
• 9eb611e7f07ebb6eb0cbcca32d644abf8352c991: 8334055: Unhelpful 'required: reference' diagnostics after JDK-8043226
• 5100303c6c5e4224d2c41f90719139bb5f4e236e: 8335668: NumberFormat integer only parsing should throw exception for edge case
• 58c98420b65bcea08f37982fdfba747005c03553: 8336021: Doccheck: valign not allowed for HTML5 in java.xml
• d06d79c80980644df511cded0eb8bc0309d878d3: 8325369: @sealedGraph: Bad link to image for tag on nested classes
• dea92742c2b5889717f2183dc29b5772daff5340: 8332125: [nmt] Totals in diff report should print out total malloc and mmap diffs
• 5c612c230b0a852aed5fd36e58b82ebf2e1838af: 8332689: RISC-V: Use load instead of trampolines
• 6fcd49f9431cc3507f96ef2acdca43fc6a394a14: 8336239: Fix javadoc markup in java.lang.Process
• b32e4a68bca588d908bd81a398eb3171a6876dc5: 8335356: Shenandoah: Improve concurrent cleanup locking
• 62cbf70346e78ca94ce6ea4ba5a308ea0a2bbfa8: 8336085: Fix simple -Wzero-as-null-pointer-constant warnings in CDS code
• ... and 85 more: https://git.openjdk.org/jdk/compare/6c84e9c8cb71aac103901c0d92fe6ae51aabff15...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@liach @nizarbenalla Pushed as commit 889055713ea83f899ebd7bf640dcf3c3e1a82ebe.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.