jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8335623: Clean up HtmlTag.HtmlTag and make the ARIA role attribute global

Open nizarbenalla opened this issue 7 months ago • 4 comments

Can I please get a review for this small change? It removes some lines that are no longer necessary and sets the ARIA role as global. Thanks in advance.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8335623: Clean up HtmlTag.HtmlTag and make the ARIA role attribute global (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20007/head:pull/20007
$ git checkout pull/20007

Update a local copy of the PR:
$ git checkout pull/20007
$ git pull https://git.openjdk.org/jdk.git pull/20007/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20007

View PR using the GUI difftool:
$ git pr show -t 20007

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20007.diff

Webrev

Link to Webrev Comment

nizarbenalla avatar Jul 03 '24 14:07 nizarbenalla