jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8334445: Parallel: Decouple maximum compaction from SoftReference clearing

Open albertnetymk opened this issue 1 year ago • 4 comments

Simple refactoring to not assume maximum-compaction from soft-ref-clearing.


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8334445: Parallel: Decouple maximum compaction from SoftReference clearing (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19763/head:pull/19763
$ git checkout pull/19763

Update a local copy of the PR:
$ git checkout pull/19763
$ git pull https://git.openjdk.org/jdk.git pull/19763/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19763

View PR using the GUI difftool:
$ git pr show -t 19763

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19763.diff

Webrev

Link to Webrev Comment

albertnetymk avatar Jun 18 '24 08:06 albertnetymk

:wave: Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jun 18 '24 08:06 bridgekeeper[bot]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334445: Parallel: Decouple maximum compaction from SoftReference clearing

Reviewed-by: zgu, lmao

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 66 new commits pushed to the master branch:

  • 3cce31ad8877ec62429981871bcb0067770f9ccb: 8335643: serviceability/dcmd/vm tests fail for ZGC after JDK-8322475
  • 55fd1ed228ea3c42aaf92579e5dcb818fe14351d: 8333890: Fatal error in auto-vectorizer with float16 kernel.
  • 02956ab6e161ca8556a73f328f79bcbfba997cbc: 8332163: C2 SuperWord: refactor PacksetGraph and SuperWord::output into VTransformGraph
  • 3f37c5718d676b7001e6a084aed3ba645745a144: 8335806: RISC-V: Corrected typos Bizarrely
  • 6f7f0f1de05fdc0f6a88ccd90b806e8a5c5074ef: 8333884: MemorySegment::reinterpret removes read-only property
  • b83766e59063a41ea8801ac9e7c15dce67727c62: 8335632: jdk/jfr/api/consumer/streaming/TestJVMExit.java failed with "Process [...] is no longer alive"
  • 7efe16038e5df9894a265ea1214068060f595c4e: 8335730: JFR: Clean up jdk.jfr
  • ff49f677ee5017019c90823bc412ceb90068ffbd: 8335775: Remove extraneous 's' in comment of rawmonitor.cpp test file
  • 194425d7875ef42fce52516ed59c81ee97720399: 8335645: j.u.Formatter#trailingZeros improved with String repeat
  • c8acea87e2c5ba6672c011ec4e57a53c55fee74b: 8335706: G1: Remove unused G1ConcurrentRefine::RemSetSamplingClosure::_cset
  • ... and 56 more: https://git.openjdk.org/jdk/compare/9046d7aee3082b6cbf79876efc1c508cb893caad...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Jun 18 '24 08:06 openjdk[bot]

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Jun 18 '24 08:06 openjdk[bot]

Webrevs

mlbridge[bot] avatar Jun 18 '24 08:06 mlbridge[bot]

Thanks for review.

/integrate

albertnetymk avatar Jul 08 '24 10:07 albertnetymk

Going to push as commit 540188fdebd089d4145eca18c0f95bf338cbcefc. Since your change was applied there have been 66 commits pushed to the master branch:

  • 3cce31ad8877ec62429981871bcb0067770f9ccb: 8335643: serviceability/dcmd/vm tests fail for ZGC after JDK-8322475
  • 55fd1ed228ea3c42aaf92579e5dcb818fe14351d: 8333890: Fatal error in auto-vectorizer with float16 kernel.
  • 02956ab6e161ca8556a73f328f79bcbfba997cbc: 8332163: C2 SuperWord: refactor PacksetGraph and SuperWord::output into VTransformGraph
  • 3f37c5718d676b7001e6a084aed3ba645745a144: 8335806: RISC-V: Corrected typos Bizarrely
  • 6f7f0f1de05fdc0f6a88ccd90b806e8a5c5074ef: 8333884: MemorySegment::reinterpret removes read-only property
  • b83766e59063a41ea8801ac9e7c15dce67727c62: 8335632: jdk/jfr/api/consumer/streaming/TestJVMExit.java failed with "Process [...] is no longer alive"
  • 7efe16038e5df9894a265ea1214068060f595c4e: 8335730: JFR: Clean up jdk.jfr
  • ff49f677ee5017019c90823bc412ceb90068ffbd: 8335775: Remove extraneous 's' in comment of rawmonitor.cpp test file
  • 194425d7875ef42fce52516ed59c81ee97720399: 8335645: j.u.Formatter#trailingZeros improved with String repeat
  • c8acea87e2c5ba6672c011ec4e57a53c55fee74b: 8335706: G1: Remove unused G1ConcurrentRefine::RemSetSamplingClosure::_cset
  • ... and 56 more: https://git.openjdk.org/jdk/compare/9046d7aee3082b6cbf79876efc1c508cb893caad...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Jul 08 '24 10:07 openjdk[bot]

@albertnetymk Pushed as commit 540188fdebd089d4145eca18c0f95bf338cbcefc.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Jul 08 '24 10:07 openjdk[bot]