8333364: Minor cleanup could be done in com.sun.crypto.provider

[mcpowers]

https://bugs.openjdk.org/browse/JDK-8333364

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8333364: Minor cleanup could be done in com.sun.crypto.provider (Bug - P4)

Reviewers

• Valerie Peng (@valeriepeng - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19535/head:pull/19535
$ git checkout pull/19535

Update a local copy of the PR:
$ git checkout pull/19535
$ git pull https://git.openjdk.org/jdk.git pull/19535/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19535

View PR using the GUI difftool:
$ git pr show -t 19535

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19535.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back mpowers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@mcpowers This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333364: Minor cleanup could be done in com.sun.crypto.provider

Reviewed-by: mullan, valeriep

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 217 new commits pushed to the master branch:

• 7e11fb702696df733ca89d325200f2e9414402d9: 8335688: Fix -Wzero-as-null-pointer-constant warnings from fflush calls in jvmti tests
• 531a6d85b00b88688668ab1ced0db6ce0214a5f1: 8335911: Document ccls indexer in doc/ide.md
• 0e0dfca21f64ecfcb3e5ed7cdc2a173834faa509: 8330806: test/hotspot/jtreg/compiler/c1/TestLargeMonitorOffset.java fails on ARM32
• f3ff4f7427c3c3f5cb2a115a61462bb9d28de1cd: 8335882: platform/cgroup/TestSystemSettings.java fails on Alpine Linux
• 8f62f31dff564289a2422d58e8ecd5062d443b81: 8335906: [s390x] Test Failure: GTestWrapper.java
• 2a2964759c73b3b9ab6afaad109383c89952977b: 8334777: Test javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java failed with NullPointerException
• 564a72e1dba0f145600c8e7eff66992fbf294df0: 8335955: JDK-8335742 wrongly used a "JDK-" prefix in the problemlist bug number
• 9c7a6eabb93c570fdb74076edc931576ed6be3e0: 8312125: Refactor CDS enum class handling
• bb1f8a1698553d5962569ac8912edd0d7ef010dd: 8335904: Fix invalid comment in ShenandoahLock
• babf6df7d97e4beedb25e689634d999412c1e950: 8334757: AssertionError: Missing type variable in where clause
• ... and 207 more: https://git.openjdk.org/jdk/compare/1b1dba8082969244effa86ac03c6053b3b0ddc43...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk[bot]]

@mcpowers The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mcpowers]

This is the last cleanup bug. After integration, the umbrella bug can be closed.

[mlbridge[bot]]

Webrevs

• 04: Full - Incremental (9e2f3521)
• 03: Full - Incremental (78a8522c)
• 02: Full - Incremental (3bf59f72)
• 01: Full - Incremental (a8b7e2bd)
• 00: Full (3472c998)

[valeriepeng]

BTW, need to add noreg-xxx label to the bug record.

[mcpowers]

Thanks for the review Valerie!

I just ran tiers 1-3 as a sanity check. All tests passed.

[mcpowers]

/integrate

[openjdk[bot]]

Going to push as commit 1472124489c841642996ae984e21c533ffec8091. Since your change was applied there have been 217 commits pushed to the master branch:

• 7e11fb702696df733ca89d325200f2e9414402d9: 8335688: Fix -Wzero-as-null-pointer-constant warnings from fflush calls in jvmti tests
• 531a6d85b00b88688668ab1ced0db6ce0214a5f1: 8335911: Document ccls indexer in doc/ide.md
• 0e0dfca21f64ecfcb3e5ed7cdc2a173834faa509: 8330806: test/hotspot/jtreg/compiler/c1/TestLargeMonitorOffset.java fails on ARM32
• f3ff4f7427c3c3f5cb2a115a61462bb9d28de1cd: 8335882: platform/cgroup/TestSystemSettings.java fails on Alpine Linux
• 8f62f31dff564289a2422d58e8ecd5062d443b81: 8335906: [s390x] Test Failure: GTestWrapper.java
• 2a2964759c73b3b9ab6afaad109383c89952977b: 8334777: Test javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java failed with NullPointerException
• 564a72e1dba0f145600c8e7eff66992fbf294df0: 8335955: JDK-8335742 wrongly used a "JDK-" prefix in the problemlist bug number
• 9c7a6eabb93c570fdb74076edc931576ed6be3e0: 8312125: Refactor CDS enum class handling
• bb1f8a1698553d5962569ac8912edd0d7ef010dd: 8335904: Fix invalid comment in ShenandoahLock
• babf6df7d97e4beedb25e689634d999412c1e950: 8334757: AssertionError: Missing type variable in where clause
• ... and 207 more: https://git.openjdk.org/jdk/compare/1b1dba8082969244effa86ac03c6053b3b0ddc43...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@mcpowers Pushed as commit 1472124489c841642996ae984e21c533ffec8091.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.