8332744: [REDO] 'internal proprietary API' diagnostics if --system is configured to an earlier JDK version

[cushon]

This change fixes a bug preventing javac from emitting 'compiler.warn.sun.proprietary' diagnostics if --system is set to a non-default value. The diagnostics are currently emitted for values of --release, and for the default value of --system.

The is a redo of JDK-8331081, which was backed out in JDK-8332740 due to a build failure in the microbenchmarks.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8332744: [REDO] 'internal proprietary API' diagnostics if --system is configured to an earlier JDK version (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19397/head:pull/19397
$ git checkout pull/19397

Update a local copy of the PR:
$ git checkout pull/19397
$ git pull https://git.openjdk.org/jdk.git pull/19397/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19397

View PR using the GUI difftool:
$ git pr show -t 19397

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19397.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@cushon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332744: [REDO] 'internal proprietary API' diagnostics if --system is configured to an earlier JDK version

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• 5890d9438bbde88b89070052926a2eafe13d7b42: 8333893: Optimization for StringBuilder append boolean & null
• c33a8f52b613e5eff02f572eda876cbbfc7c22cf: 8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file
• 16feeb7a8e9a02fec4846179fcfbdc3a71b07fe5: 8343547: Restore accidentally removed annotations in LambdaForm from ClassFile API port
• f62fc4844125cc20a91dc2be39ba05a2d3aca8cf: 8342498: Add test for Allocation elimination after use as alignment reference by SuperWord
• f3671beefb3ff07441a905e25619f0d1a0a2fe15: 8335392: C2 MergeStores: enhanced pointer parsing
• 4fc6d4135e795d18a024a6035908f380b81082d1: 8341194: [REDO] Implement C2 VectorizedHashCode on AArch64
• abf2dc7128fc0644e85bca32d8f3beacc876cecb: 8343298: Improve stability of runtime/cds/DeterministicDump.java test
• dafa2e55adb6b054c342d5e723e51087d771e6d6: 8343124: Tests fails with java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainTask cannot access
• 0f7dd98d9d546e0fc2c7b1df779cef35e5b5852c: 8251926: PPC: Remove an unused variable in assembler_ppc.cpp
• cd91a44500e83f84e8e9ecc2760552dd18860842: 8343549: SeededSecureRandomTest needn't be in a package
• ... and 2 more: https://git.openjdk.org/jdk/compare/714472d8a5b3d16b870bc272ce8664cd62733857...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk[bot]]

@cushon The following labels will be automatically applied to this pull request:

• compiler
• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 03: Full - Incremental (a56bc3a5)
• 02: Full - Incremental (aa688777)
• 01: Full - Incremental (e8ba518a)
• 00: Full (6cd4fed2)

[bridgekeeper[bot]]

@cushon This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[cushon]

bridgekeeper please keep this open for now

[bridgekeeper[bot]]

@cushon This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[cushon]

I still think it'd be slightly worthwhile to fix the built-in sunapi implementation to handle this case, but if the feeling is that it isn't worth spending time on and the possible disruption to -Werror, that's also OK.

[bridgekeeper[bot]]

@cushon This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@cushon This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[cushon]

/open

[openjdk[bot]]

@cushon This pull request is now open

[cushon]

@vicente-romero-oracle could you please take another look?

I was preparing to integrate this, and the latest merge includes one new benchmark that requires another update: https://github.com/openjdk/jdk/pull/19397/commits/a56bc3a5d461f2f27ee77e169d7bc6b9e80247cb

[vicente-romero-oracle]

@cushon done, thanks

[cushon]

/integrate

[openjdk[bot]]

Going to push as commit 839de82c314697d7461b77caa9d85407e3578de3. Since your change was applied there have been 17 commits pushed to the master branch:

• 8cb122119409fb13b4b9b2e74851207734d5c198: 8343532: Test test/hotspot/jtreg/runtime/cds/appcds/jigsaw/addmods/AddmodsOption.java fails on Linux ppc64le after JDK-8319343
• fbf9b96b6103250a2f72c3cbc47d73e9ddea6dbd: 8343480: Remove unnecessary @SuppressWarnings annotations (javadoc)
• f95097cc64f1d7647f8328b623e9bd9f1180b6d8: 8343482: Remove unnecessary @SuppressWarnings annotations (net)
• c799cad1de93aadfe60d9cbccb0499d7299f0598: 8343486: Remove unnecessary @SuppressWarnings annotations and -Xlint:-foo options
• 0b733e9a22fd786f3fd133faae3b00d31258e755: 8336874: WhiteBoxAPI: assert(!method->is_abstract() && (osr_bci == InvocationEntryBci || !method->is_native())) failed: cannot compile abstract/native methods
• 5890d9438bbde88b89070052926a2eafe13d7b42: 8333893: Optimization for StringBuilder append boolean & null
• c33a8f52b613e5eff02f572eda876cbbfc7c22cf: 8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file
• 16feeb7a8e9a02fec4846179fcfbdc3a71b07fe5: 8343547: Restore accidentally removed annotations in LambdaForm from ClassFile API port
• f62fc4844125cc20a91dc2be39ba05a2d3aca8cf: 8342498: Add test for Allocation elimination after use as alignment reference by SuperWord
• f3671beefb3ff07441a905e25619f0d1a0a2fe15: 8335392: C2 MergeStores: enhanced pointer parsing
• ... and 7 more: https://git.openjdk.org/jdk/compare/714472d8a5b3d16b870bc272ce8664cd62733857...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@cushon Pushed as commit 839de82c314697d7461b77caa9d85407e3578de3.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.