jdk icon indicating copy to clipboard operation
jdk copied to clipboard

fix hasJDKEvents remove Network IO JFR events and file force events since they had been made static mirror events

Open NeatGuyCoding opened this issue 1 year ago • 6 comments

According to:


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [ ] Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19267/head:pull/19267
$ git checkout pull/19267

Update a local copy of the PR:
$ git checkout pull/19267
$ git pull https://git.openjdk.org/jdk.git pull/19267/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19267

View PR using the GUI difftool:
$ git pr show -t 19267

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19267.diff

NeatGuyCoding avatar May 16 '24 11:05 NeatGuyCoding

Hi @HashJang, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user HashJang" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

bridgekeeper[bot] avatar May 16 '24 11:05 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar May 16 '24 11:05 openjdk[bot]

@HashJang The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar May 16 '24 12:05 openjdk[bot]

/signed https://oca.opensource.oracle.com/api/v1/oca-requests/8617/documents/8597/download

NeatGuyCoding avatar May 16 '24 12:05 NeatGuyCoding

/signed /signed

NeatGuyCoding avatar May 16 '24 12:05 NeatGuyCoding

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

bridgekeeper[bot] avatar May 16 '24 12:05 bridgekeeper[bot]

@HashJang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jun 13 '24 14:06 bridgekeeper[bot]

oca still not verified?

NeatGuyCoding avatar Jun 17 '24 07:06 NeatGuyCoding

internal review ID : 9077285

NeatGuyCoding avatar Jul 09 '24 06:07 NeatGuyCoding

Events located in java.base also need instrumentation, regardless if the commit method is static or not.

egahlin avatar Jul 19 '24 13:07 egahlin

@HashJang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Aug 16 '24 16:08 bridgekeeper[bot]

@HashJang This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Sep 13 '24 19:09 bridgekeeper[bot]