jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8332153: RISC-V: enable tests and add comment for vector shift instruct (shared by vectorization and Vector API)

Open Hamlin-Li opened this issue 9 months ago • 4 comments

Hi, Can you help to review this patch? For vector shift instruct, some corresponding tests are not enabled, this is to enable them. And the way how vector shift instruct works is not clear, especially both vectorization (SLP in jdk) and Vector API share the same instruct's in riscv_v.ad, so also added some comment to clarify it.

Thanks


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8332153: RISC-V: enable tests and add comment for vector shift instruct (shared by vectorization and Vector API) (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19265/head:pull/19265
$ git checkout pull/19265

Update a local copy of the PR:
$ git checkout pull/19265
$ git pull https://git.openjdk.org/jdk.git pull/19265/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19265

View PR using the GUI difftool:
$ git pr show -t 19265

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19265.diff

Webrev

Link to Webrev Comment

Hamlin-Li avatar May 16 '24 11:05 Hamlin-Li