jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8331432: Clean up comments in GenArguments::initialize_size_info()

Open xiaotaonan opened this issue 9 months ago • 5 comments

Clean up comments in GenArguments::initialize_size_info()


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8331432: Clean up comments in GenArguments::initialize_size_info() (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19223/head:pull/19223
$ git checkout pull/19223

Update a local copy of the PR:
$ git checkout pull/19223
$ git pull https://git.openjdk.org/jdk.git pull/19223/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19223

View PR using the GUI difftool:
$ git pr show -t 19223

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19223.diff

Webrev

Link to Webrev Comment

xiaotaonan avatar May 14 '24 00:05 xiaotaonan

:wave: Welcome back xiaotaonan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar May 14 '24 00:05 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar May 14 '24 00:05 openjdk[bot]

@xiaotaonan The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar May 14 '24 00:05 openjdk[bot]

Webrevs

mlbridge[bot] avatar May 14 '24 00:05 mlbridge[bot]

@lgxbslgx

xiaotaonan avatar May 15 '24 22:05 xiaotaonan

The issue states there are two places which need to be revised. So the warning message is good to be adjusted in this PR.

lgxbslgx avatar May 21 '24 12:05 lgxbslgx

@xiaotaonan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jun 19 '24 04:06 bridgekeeper[bot]

@xiaotaonan this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8331432
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

openjdk[bot] avatar Jun 24 '24 05:06 openjdk[bot]

@xiaotaonan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jul 22 '24 08:07 bridgekeeper[bot]

@xiaotaonan This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Aug 19 '24 13:08 bridgekeeper[bot]