jdk
jdk copied to clipboard
8331432: Clean up comments in GenArguments::initialize_size_info()
Clean up comments in GenArguments::initialize_size_info()
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8331432: Clean up comments in GenArguments::initialize_size_info() (Enhancement - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19223/head:pull/19223
$ git checkout pull/19223
Update a local copy of the PR:
$ git checkout pull/19223
$ git pull https://git.openjdk.org/jdk.git pull/19223/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19223
View PR using the GUI difftool:
$ git pr show -t 19223
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19223.diff
Webrev
:wave: Welcome back xiaotaonan! A progress list of the required criteria for merging this PR into master
will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
@xiaotaonan The following label will be automatically applied to this pull request:
-
hotspot-gc
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
@lgxbslgx
The issue states there are two places which need to be revised. So the warning message is good to be adjusted in this PR.
@xiaotaonan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@xiaotaonan this pull request can not be integrated into master
due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:
git checkout JDK-8331432
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push
@xiaotaonan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@xiaotaonan This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open
pull request command.