jdk
jdk copied to clipboard
openjdk
8331975: Enable case-insensitive check in ccache and keytab entry lookup
Add a new system property to control the name comparison in keytab and ccache entry lookup.
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] Change requires CSR request JDK-8331976 to be approved
Issues
- JDK-8331975: Enable case-insensitive check in ccache and keytab entry lookup (Enhancement - P4)
- JDK-8331976: Enable case-insensitive check in ccache and keytab entry lookup (CSR)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19216/head:pull/19216
$ git checkout pull/19216
Update a local copy of the PR:
$ git checkout pull/19216
$ git pull https://git.openjdk.org/jdk.git pull/19216/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19216
View PR using the GUI difftool:
$ git pr show -t 19216
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19216.diff
Webrev
:wave: Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@wangweij This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8331975: Enable case-insensitive check in ccache and keytab entry lookup
Reviewed-by: mpowers, valeriep
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 142 new commits pushed to the master branch:
- 424eb60dedb332237b8ec97e9da6bd95442c0083: 8331683: Clean up GetCarrierThread
- 9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
- f8a3e4e428f7d3e62177bdf148fe25e22d3ee2bf: 8328998: Encoding support for Intel APX extended general-purpose registers
- ddd73b458355bffeaa8e0e5017c27d6c6af2dc94: 8332082: Shenandoah: Use consistent tests to determine when pre-write barrier is active
- 0a9d1f8c89e946d99f01549515f6044e53992168: 8332749: Broken link in MemorySegment.Scope.html
- c9a7b9772d96d9a4825d9da2aacc277534282860: 8332829: [BACKOUT] C2: crash in compiled code because of dependency on removed range check CastIIs
- 7fd9d6c760c66d3e2f4034cf1a6b1b583ff829a9: 8332340: Add JavacBench as a test case for CDS
- 417d174aa1b7bd3b5755e5f2352d9bbe6ce6f183: 8331348: Some incremental builds deposit files in the make directory
- 303ac9f270f567d821d156f3a9d4f4c070f43f95: 8332671: Logging for pretouching thread stacks shows wrong memory range
- 90758f6735620776fcb60da9e0e2c91a4f53aaf1: 8332808: Always set java.io.tmpdir to a suitable value in the build
- ... and 132 more: https://git.openjdk.org/jdk/compare/1dac34fa757f1d603f0bc9b9c1994c114c276add...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
@wangweij The following label will be automatically applied to this pull request:
-
security
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
Are there any existing interoperability tests?
Not with real KDCs, but I can probably enhance the test to cover the case when this prop is not set.
Are there any existing interoperability tests?
Not with real KDCs, but I can probably enhance the test to cover the case when this prop is not set.
I can only confirm that the default behavior works with Active Directory KDC.
Changes look good to me. Thanks~
Thanks a lot! Can you please also review the CSR?
Going to push as commit da3001daf79bf943d6194d9fd60250d519b9680d.
Since your change was applied there have been 142 commits pushed to the master branch:
- 424eb60dedb332237b8ec97e9da6bd95442c0083: 8331683: Clean up GetCarrierThread
- 9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
- f8a3e4e428f7d3e62177bdf148fe25e22d3ee2bf: 8328998: Encoding support for Intel APX extended general-purpose registers
- ddd73b458355bffeaa8e0e5017c27d6c6af2dc94: 8332082: Shenandoah: Use consistent tests to determine when pre-write barrier is active
- 0a9d1f8c89e946d99f01549515f6044e53992168: 8332749: Broken link in MemorySegment.Scope.html
- c9a7b9772d96d9a4825d9da2aacc277534282860: 8332829: [BACKOUT] C2: crash in compiled code because of dependency on removed range check CastIIs
- 7fd9d6c760c66d3e2f4034cf1a6b1b583ff829a9: 8332340: Add JavacBench as a test case for CDS
- 417d174aa1b7bd3b5755e5f2352d9bbe6ce6f183: 8331348: Some incremental builds deposit files in the make directory
- 303ac9f270f567d821d156f3a9d4f4c070f43f95: 8332671: Logging for pretouching thread stacks shows wrong memory range
- 90758f6735620776fcb60da9e0e2c91a4f53aaf1: 8332808: Always set java.io.tmpdir to a suitable value in the build
- ... and 132 more: https://git.openjdk.org/jdk/compare/1dac34fa757f1d603f0bc9b9c1994c114c276add...master
Your commit was automatically rebased without conflicts.
@wangweij Pushed as commit da3001daf79bf943d6194d9fd60250d519b9680d.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.