jdk
jdk copied to clipboard
openjdk
8332086: Remove the usage of ServiceLoader in j.u.r.RandomGeneratorFactory
All random number generator algorithms are implemented in module java.base. The usage of ServiceLoader in j.u.r.RandomGeneratorFactory is no longer needed.
Progress
- [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] Change requires CSR request JDK-8332477 to be approved
Warning
⚠️ Found leading lowercase letter in issue title for 8332476: j.u.r.RandomGeneratorFactor.create(long|byte[]) should throw rather than silently fallback to no-arg create()
Issues
- JDK-8332086: Remove the usage of ServiceLoader in j.u.r.RandomGeneratorFactory (Bug - P4)
- JDK-8332476: j.u.r.RandomGeneratorFactor.create(long|byte[]) should throw rather than silently fallback to no-arg create() (Bug - P4)
- JDK-8332131: Remove the usage of ServiceLoader in j.u.r.RandomGeneratorFactory (CSR) (Withdrawn)
- JDK-8332477: j.u.r.RandomGeneratorFactor.create(long|byte[]) should throw rather than silently fallback to no-arg create() (CSR)
Reviewers
- Jaikiran Pai (@jaikiran - Reviewer)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19212/head:pull/19212
$ git checkout pull/19212
Update a local copy of the PR:
$ git checkout pull/19212
$ git pull https://git.openjdk.org/jdk.git pull/19212/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19212
View PR using the GUI difftool:
$ git pr show -t 19212
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19212.diff
Webrev
:wave: Welcome back rgiulietti! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@rgiulietti This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8332086: Remove the usage of ServiceLoader in j.u.r.RandomGeneratorFactory
8332476: j.u.r.RandomGeneratorFactor.create(long|byte[]) should throw rather than silently fallback to no-arg create()
Reviewed-by: jpai
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 143 new commits pushed to the master branch:
- 9bfae8891e6efa58c557bd6dac61de111a16f71e: 8332297: annotation processor that generates records sometimes fails due to NPE in javac
- 4e169d1ed7501d1de8fd4ea326f84b6c1a34270d: 8332401: G1: TestFromCardCacheIndex.java with -XX:GCCardSizeInBytes=128 triggers underflow assertion
- 7ffc9997bd4a93cefe30f672a5f0e9c49215d2c7: 8332498: [aarch64, x86] improving OpToAssembly output for partialSubtypeCheckConstSuper Instruct
- e529101ea30b49a6601088ce5ab81df590fc52f0: 8332473: ubsan: growableArray.hpp:290:10: runtime error: null pointer passed as argument 1, which is declared to never be null
- 414a7fdc5e4aae4cec25b0847bb7c163f271b4e0: 8311175: Move BufWriter::asByteBuffer to BufWriterImpl
- 451cc239050f097060be927171fe0e46962f3356: 8332486: ClassFile API ArrayIndexOutOfBoundsException with label metadata
- 5f2b8d0224868d09ff54e93fabe4a6db177aef8f: 8332448: Make SpaceMangler inherit AllStatic
- 8a49d47cf3e845ddccaaeafeee9dfe6ab3180ded: 8332462: ubsan: c1_ValueStack.hpp:229:49: runtime error: load of value 171, which is not a valid value for type 'bool'
- ce99198e3a6dc81865c518b1fe4a67e93b8ebdd1: 8332181: Deprecate for removal the MulticastSocket.send(DatagramPacket, byte) and setTTL/getTTL methods on DatagramSocketImpl and MulticastSocket
- f5ab7dff402a3152f5d5736cc6521b4be617eccf: 8332494: java/util/zip/EntryCount64k.java failing with java.lang.RuntimeException: '\A\Z' missing from stderr
- ... and 133 more: https://git.openjdk.org/jdk/compare/7f299043a99406dbd666d4f7f30445d26f3eae82...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
@rgiulietti The following label will be automatically applied to this pull request:
-
core-libs
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
Webrevs
- 07: Full - Incremental (87813996)
- 06: Full - Incremental (880138d7)
- 05: Full - Incremental (a77146f5)
- 04: Full - Incremental (920655a5)
- 03: Full - Incremental (4bc5bf95)
- 02: Full - Incremental (e8432cc6)
- 01: Full - Incremental (6179b5e8)
- 00: Full (09450c09)
This is a followup of 18932 in which all random number generator algorithms have been moved to module java.base and module jdk.random has been removed.
Reliance on ServiceLoader in j.u.r.RandomGeneratorFactory is no longer needed and has been replaced by a (lazily populated) map from algorithm names to classes.
Moreover, methods RandomGeneratorFactory.create(long) and create(byte[]) now throw an UnsupportedOperationException rather than silently falling back to the no-arg create() in case the underlying algorithm does not support a long resp. byte[] seed.
Tests in tier1-tier3 pass after adaptations on the existing RandomTestCoverage.
Thank you for these updates Raffaello. I think the implementation is looking much more simpler and cleaner now. I've a few documentation related review comments which I've added inline. I haven't reviewed the test change yet.
@rgiulietti
Adding additional issue to issue list: 8332476: j.u.r.RandomGeneratorFactor.create(long|byte[]) should throw rather than silently fallback to no-arg create().
@rgiulietti
Updating description of additional solved issue: 8332476: j.u.r.RandomGeneratorFactor.create(long|byte[]) should throw rather than silently fallback to no-arg create().
Going to push as commit 42e3c842ae2684265c794868fc76eb0ff2dea3d9.
Since your change was applied there have been 146 commits pushed to the master branch:
- 5cf8288b8071bdcf0c923dd7ba36f91bc7594ef3: 8332153: RISC-V: enable tests and add comment for vector shift instruct (shared by vectorization and Vector API)
- ae9ad862ee54e119553efec919f1061dca36b954: 8331934: [s390x] Add support for primitive array C1 clone intrinsic
- 3479b46c5bea3afd92b6ab4acd2fe7f274df38aa: 8332595: Serial: Remove unused TenuredGeneration::should_collect
- 9bfae8891e6efa58c557bd6dac61de111a16f71e: 8332297: annotation processor that generates records sometimes fails due to NPE in javac
- 4e169d1ed7501d1de8fd4ea326f84b6c1a34270d: 8332401: G1: TestFromCardCacheIndex.java with -XX:GCCardSizeInBytes=128 triggers underflow assertion
- 7ffc9997bd4a93cefe30f672a5f0e9c49215d2c7: 8332498: [aarch64, x86] improving OpToAssembly output for partialSubtypeCheckConstSuper Instruct
- e529101ea30b49a6601088ce5ab81df590fc52f0: 8332473: ubsan: growableArray.hpp:290:10: runtime error: null pointer passed as argument 1, which is declared to never be null
- 414a7fdc5e4aae4cec25b0847bb7c163f271b4e0: 8311175: Move BufWriter::asByteBuffer to BufWriterImpl
- 451cc239050f097060be927171fe0e46962f3356: 8332486: ClassFile API ArrayIndexOutOfBoundsException with label metadata
- 5f2b8d0224868d09ff54e93fabe4a6db177aef8f: 8332448: Make SpaceMangler inherit AllStatic
- ... and 136 more: https://git.openjdk.org/jdk/compare/7f299043a99406dbd666d4f7f30445d26f3eae82...master
Your commit was automatically rebased without conflicts.
@rgiulietti Pushed as commit 42e3c842ae2684265c794868fc76eb0ff2dea3d9.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.