jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8332098: Add missing @ since tags to jdk.jdi

Open nizarbenalla opened this issue 9 months ago • 11 comments

Please review this simple change where I add "@ since" tags to the package-info file of the following packages

com.sun.jdi com.sun.jdi.connect com.sun.jdi.connect.spi com.sun.jdi.event com.sun.jdi.request

I used the unix grep command to find the oldest "@ since" in each package and used that value, as it's hard to get the source code of JDK 1-5 TIA


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8332098: Add missing @ since tags to jdk.jdi (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19200/head:pull/19200
$ git checkout pull/19200

Update a local copy of the PR:
$ git checkout pull/19200
$ git pull https://git.openjdk.org/jdk.git pull/19200/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19200

View PR using the GUI difftool:
$ git pr show -t 19200

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19200.diff

Webrev

Link to Webrev Comment

nizarbenalla avatar May 12 '24 01:05 nizarbenalla

:wave: Welcome back nizarbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar May 12 '24 01:05 bridgekeeper[bot]

@nizarbenalla This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332098: Add missing @ since tags to jdk.jdi

Reviewed-by: alanb, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

  • 61aff6db15d5bdda77427af5ce34d0fe43373197: 8332112: Update nsk.share.Log to don't print summary during VM shutdown hook
  • 30bb066b1982c5318d54bfe74115306c602e2974: 8332003: Clarify javadoc for MemoryLayout::offsetHandle
  • c4867c62c44b48e48845608fe4b29b58749767ad: 8329273: C2 SuperWord: Some basic MemorySegment IR tests
  • 8032d640c0d34fe507392a1d4faa4ff2005c771d: 8332245: C2: missing record_for_ign() call in GraphKit::must_be_not_null()
  • fa043aec425ae1e3086d09492b3fabcfbd3fa779: 8294880: Review running time of jdk/internal/shellsupport/doc/JavadocHelperTest.java
  • a5005c87c4d5598eb54e9824105767d833f9660b: 8330814: Cleanups for KeepAliveCache tests
  • 1a944478a26a766f5a573a1236b642d8e7b0685c: 8332111: [BACKOUT] A way to align already compiled methods with compiler directives
  • 957eb611ce2531a3fcc764813ad1e0776887fdda: 8331429: [JVMCI] Cleanup JVMCIRuntime allocation routines
  • 2f10a316ff0c5a4c124b94f6fabb38fb119d2c82: 8302850: Implement C1 clone intrinsic that reuses arraycopy code for primitive arrays
  • c642f44bbe1e4cdbc23496a34ddaae30990ce7c0: 8329839: Cleanup ZPhysicalMemoryBacking trace logging
  • ... and 24 more: https://git.openjdk.org/jdk/compare/32c7681cf310c87669c502c4a8b62a7fecc93360...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman, @plummercj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar May 12 '24 01:05 openjdk[bot]

@nizarbenalla The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar May 12 '24 02:05 openjdk[bot]

Webrevs

mlbridge[bot] avatar May 12 '24 19:05 mlbridge[bot]

JPDA was added to the JDK in JDK 1.3. The support for pluggable connectors (added com.sun.jdi.connect.spi package) was JDK 5. So I think this looks okay.

AlanBateman avatar May 13 '24 06:05 AlanBateman

/integrate

nizarbenalla avatar May 13 '24 08:05 nizarbenalla

@nizarbenalla Your change (at version 39b7ee70679b6cbed07c4d78f6439fa53c92f889) is now ready to be sponsored by a Committer.

openjdk[bot] avatar May 13 '24 08:05 openjdk[bot]

Can you fix the summary of the CR to not have backwards quotes. This seems to cause git some grief, as can be seen where the CR is mentioned in the Issue section of the PR description.

plummercj avatar May 13 '24 18:05 plummercj

Done, I tend to use them for formatting. And there are users with names such as "@ since" that would keep getting tagged.

nizarbenalla avatar May 13 '24 19:05 nizarbenalla

/integrate

nizarbenalla avatar May 13 '24 19:05 nizarbenalla

@nizarbenalla Your change (at version 2ec2b5296d0a46298f7023da1fcf67f8455edc2e) is now ready to be sponsored by a Committer.

openjdk[bot] avatar May 13 '24 19:05 openjdk[bot]

No changes have been done to the PR since it was last approved by Chris few days back (that's a good thing). I'll go ahead and sponsor this now.

jaikiran avatar May 16 '24 11:05 jaikiran

/sponsor

jaikiran avatar May 16 '24 11:05 jaikiran

Going to push as commit a33cb9045b2c0cae7d894715d1484e77b7607de6. Since your change was applied there have been 50 commits pushed to the master branch:

  • 910d77becd15580296687b00fed085ab106cb2eb: 8331953: ubsan: metaspaceShared.cpp:1305:57: runtime error: applying non-zero offset 12849152 to null pointer
  • f9f8d0b48057a02923e36c8e11286b57cc72279e: 8332101: Add an @since to StandardOperation:REMOVE in jdk.dynalink
  • f398cd225012694a586e528936159b6df7b1586c: 8331575: C2: crash when ConvL2I is split thru phi at LongCountedLoop
  • 96c5c3fe75103dc45bc1c3ccce0ab36303121a60: 8329998: Remove double initialization for parts of small TypeArrays in ZObjArrayAllocator
  • ee4a9d34827166ff9ac04e2375058fdc08e43194: 8321622: ClassFile.verify(byte[] bytes) throws unexpected ConstantPoolException, IAE
  • ab8d7b0cedfaae124262325cd1d4b59cef996d85: 8324517: C2: crash in compiled code because of dependency on removed range check CastIIs
  • fe8a2aff3129b515c2a0f3ab96f5e3ad6cef7b70: 8307778: com/sun/jdi/cds tests fail with jtreg's Virtual test thread factory
  • 95f79c678737fb8de9ed45c516761d4d818869ef: 8332253: Linux arm32 build fails after 8292591
  • b687aa550837830b38f0f0faa69c353b1e85219c: 8332176: Refactor ClassListParser::parse()
  • 4083255440cfbf39b9683ea88a433d71ec6111e7: 8316138: Add GlobalSign 2 TLS root certificates
  • ... and 40 more: https://git.openjdk.org/jdk/compare/32c7681cf310c87669c502c4a8b62a7fecc93360...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar May 16 '24 11:05 openjdk[bot]

@jaikiran @nizarbenalla Pushed as commit a33cb9045b2c0cae7d894715d1484e77b7607de6.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar May 16 '24 11:05 openjdk[bot]