jdk
jdk copied to clipboard
8332099: Add `@since` to package-info in `jdk.jsobject`
Simple code cleanup. If you're reviewing this, thanks.
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8332099: Add
@<!---->sinceto package-info injdk.jsobject(Bug - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19197/head:pull/19197
$ git checkout pull/19197
Update a local copy of the PR:
$ git checkout pull/19197
$ git pull https://git.openjdk.org/jdk.git pull/19197/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19197
View PR using the GUI difftool:
$ git pr show -t 19197
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19197.diff
Webrev
:wave: Welcome back nizarbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@nizarbenalla This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8332099: since-checker - Add @ since to package-info in jdk.jsobject
Reviewed-by: prr
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 487 new commits pushed to the master branch:
- e965d70a7425bec78620a2ca8bfaca3c392edf6a: 8333876: C2 SuperWord: regression after JDK-8325155: failed: internal connection
- 6f860f8f6f69369130ed79e71255005b5beed45a: 8334430: Clean up nativeInst_x86.*
- 8bc2fbe57893b110fdb5fd567df4615e7833e5ae: 8333769: Pretouching tests dont test pretouching
- 91bd85d65dff9cea91b88da7ef241be5c7b85f94: 8333854: IllegalAccessError with proxies after JDK-8332457
- e681b4e9b3ae24f45d8c6adab4105df39e6b8a92: 8332524: Instead of printing "TLSv1.3," it is showing "TLS13"
- fa401f37dffe7bde27e562065dfd24381d5237cc: 8333805: Replaying compilation with null static final fields results in a crash
- 472b935b442f7f925b665c7de91eda77f3dcbe8b: 8334332: TestIOException.java fails if run by root
- 614b99a8f8360dc0a6a018f06fb336c6883f0f4a: 8334442: Temporarily disable return type assertion to reduce noise in testing
- d4c13737171b7ab7a8a29a69fa9965f8363c5aee: 8334043: VerifyError when inner class is accessed in prologue
- b42fe86e817ec6975c869f46922797f546734ee0: 8334097: Parallel: Obsolete HeapFirstMaximumCompactionCount
- ... and 477 more: https://git.openjdk.org/jdk/compare/32c7681cf310c87669c502c4a8b62a7fecc93360...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace) but any other Committer may sponsor as well.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
@nizarbenalla To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.
Applicable Labels
buildclientcompilercore-libsgraalhotspothotspot-compilerhotspot-gchotspot-jfrhotspot-runtimei18nide-supportjavadocjdkjmxkullanetniosecurityserviceabilityshenandoah
/label add client
@AlanBateman
The client label was successfully added.
@nizarbenalla This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
keep alive
/integrate
@nizarbenalla Your change (at version cfadd6e70d2ad5ae2b376c597c5b3678dee5e05e) is now ready to be sponsored by a Committer.
/sponsor
Going to push as commit 1ff5acdafff1ccd3e64c70eebbfbff75e0d783eb.
Since your change was applied there have been 532 commits pushed to the master branch:
- 689cee3d0950e15e88a1f6738bfded00655dca9c: 8334509: Cancelling PageDialog does not return the same PageFormat object
- 8e1d2b091c9a311d98a0b886a803fb18d4405d8a: 8334441: Mark tests in jdk_security_infra group as manual
- 93d98027649615afeeeb6a9510230d9655a74a8f: 8334715: [riscv] Mixed use of tab and whitespace in riscv.ad
- c41293a70834a79c79e859ebcdb8869884ac87dc: 8334695: Fix build failure without zgc after JDK-8333300
- 75bea280b9adb6dac9fefafbb3f4b212f100fbb5: 8333867: SHA3 performance can be improved
- 9f8de221d7f0186718411ab3f5217e3883237e84: 8327793: Deprecate jstatd for removal
- dbf5a9a4006020ddebcce89692ce8826b6b2db46: 8334706: [JVMCI] APX registers incorrectly exposed on AMD64
- 08ace27da1d9cd215c77471eabf41417ff6282d2: 8332314: Add window size configuration option to JavaShellToolBuilder interface
- 711e7238196a4ef9211ed4cca15c7c1d774df019: 6967482: TAB-key does not work in JTables after selecting details-view in JFileChooser
- d2bebffb1fd26fae4526afd33a818ee776b7102e: 8327370: (ch) sun.nio.ch.Poller.register throws AssertionError
- ... and 522 more: https://git.openjdk.org/jdk/compare/32c7681cf310c87669c502c4a8b62a7fecc93360...master
Your commit was automatically rebased without conflicts.
@prrace @nizarbenalla Pushed as commit 1ff5acdafff1ccd3e64c70eebbfbff75e0d783eb.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.