JDK

[rizwan-r-r]

#585 #19112 #19165 #18151 #13703 #2643 #17431

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [ ] Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19196/head:pull/19196
$ git checkout pull/19196

Update a local copy of the PR:
$ git checkout pull/19196
$ git pull https://git.openjdk.org/jdk.git pull/19196/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19196

View PR using the GUI difftool:
$ git pr show -t 19196

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19196.diff

[bridgekeeper[bot]]

Hi @rizwan-r-r, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user rizwan-r-r" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk[bot]]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

[openjdk[bot]]

:warning: @rizwan-r-r a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master f47fc867b3518cb285d39f7b157bf7fde87b2083
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

[openjdk[bot]]

@rizwan-r-r The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[nizarbenalla]

Please create a new branch when contributing, don't push to master on your own fork I recommended reading this https://openjdk.org/guide/#working-with-pull-requests and a bit more in the guide, to know the title format should look like and how to sign the OCA. Though I am sure what value this fix is meant to add exactly?

[bridgekeeper[bot]]

@rizwan-r-r This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@rizwan-r-r This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.