jdk icon indicating copy to clipboard operation
jdk copied to clipboard

Published 20 hours ago • verified publisher icon openjdk

8332101: Add an `@since` to `StandardOperation:REMOVE` in `jdk.dynalink`

Open nizarbenalla opened this issue 9 months ago • 6 comments

Code cleanup, please review this simple change. I split my changes into 1 PR per module to make reviewing simpler. To help with the review, this was added back in https://bugs.openjdk.org/browse/JDK-8191905 TIA

Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8332101: Add an @<!---->since to StandardOperation:REMOVE in jdk.dynalink (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19189/head:pull/19189
$ git checkout pull/19189

Update a local copy of the PR:
$ git checkout pull/19189
$ git pull https://git.openjdk.org/jdk.git pull/19189/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19189

View PR using the GUI difftool:
$ git pr show -t 19189

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19189.diff

Webrev

Link to Webrev Comment

nizarbenalla avatar May 11 '24 15:05 nizarbenalla

:wave: Welcome back nizarbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar May 11 '24 15:05 bridgekeeper[bot]

@nizarbenalla This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332101: Add an `@since` to `StandardOperation:REMOVE` in `jdk.dynalink`

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 102 new commits pushed to the master branch:

  • f398cd225012694a586e528936159b6df7b1586c: 8331575: C2: crash when ConvL2I is split thru phi at LongCountedLoop
  • 96c5c3fe75103dc45bc1c3ccce0ab36303121a60: 8329998: Remove double initialization for parts of small TypeArrays in ZObjArrayAllocator
  • ee4a9d34827166ff9ac04e2375058fdc08e43194: 8321622: ClassFile.verify(byte[] bytes) throws unexpected ConstantPoolException, IAE
  • ab8d7b0cedfaae124262325cd1d4b59cef996d85: 8324517: C2: crash in compiled code because of dependency on removed range check CastIIs
  • fe8a2aff3129b515c2a0f3ab96f5e3ad6cef7b70: 8307778: com/sun/jdi/cds tests fail with jtreg's Virtual test thread factory
  • 95f79c678737fb8de9ed45c516761d4d818869ef: 8332253: Linux arm32 build fails after 8292591
  • b687aa550837830b38f0f0faa69c353b1e85219c: 8332176: Refactor ClassListParser::parse()
  • 4083255440cfbf39b9683ea88a433d71ec6111e7: 8316138: Add GlobalSign 2 TLS root certificates
  • 43b109b111e77d0f7b302debc0d76e4ac7c9ac56: 8330066: HeapDumpPath and HeapDumpGzipLevel VM options do not mention HeapDumpBeforeFullGC and HeapDumpAfterFullGC
  • 7cff04fc8a8114a297437aa526b18b6185831eac: 8330276: Console methods with explicit Locale
  • ... and 92 more: https://git.openjdk.org/jdk/compare/8af606fb8cdb3a6ecdfe4cddd79f228b64d5fc80...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jaikiran) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar May 11 '24 15:05 openjdk[bot]

@nizarbenalla To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

openjdk[bot] avatar May 11 '24 15:05 openjdk[bot]

I believe jdk.nashorn is under core-libs

/label core-libs

nizarbenalla avatar May 11 '24 16:05 nizarbenalla

@nizarbenalla The core-libs label was successfully added.

openjdk[bot] avatar May 11 '24 16:05 openjdk[bot]

Webrevs

mlbridge[bot] avatar May 12 '24 18:05 mlbridge[bot]

/integrate

nizarbenalla avatar May 16 '24 10:05 nizarbenalla

@nizarbenalla Your change (at version 642b8506e4a85b2e0609f63c93ef179e72843599) is now ready to be sponsored by a Committer.

openjdk[bot] avatar May 16 '24 10:05 openjdk[bot]

/sponsor

jaikiran avatar May 16 '24 10:05 jaikiran

Going to push as commit f9f8d0b48057a02923e36c8e11286b57cc72279e. Since your change was applied there have been 102 commits pushed to the master branch:

  • f398cd225012694a586e528936159b6df7b1586c: 8331575: C2: crash when ConvL2I is split thru phi at LongCountedLoop
  • 96c5c3fe75103dc45bc1c3ccce0ab36303121a60: 8329998: Remove double initialization for parts of small TypeArrays in ZObjArrayAllocator
  • ee4a9d34827166ff9ac04e2375058fdc08e43194: 8321622: ClassFile.verify(byte[] bytes) throws unexpected ConstantPoolException, IAE
  • ab8d7b0cedfaae124262325cd1d4b59cef996d85: 8324517: C2: crash in compiled code because of dependency on removed range check CastIIs
  • fe8a2aff3129b515c2a0f3ab96f5e3ad6cef7b70: 8307778: com/sun/jdi/cds tests fail with jtreg's Virtual test thread factory
  • 95f79c678737fb8de9ed45c516761d4d818869ef: 8332253: Linux arm32 build fails after 8292591
  • b687aa550837830b38f0f0faa69c353b1e85219c: 8332176: Refactor ClassListParser::parse()
  • 4083255440cfbf39b9683ea88a433d71ec6111e7: 8316138: Add GlobalSign 2 TLS root certificates
  • 43b109b111e77d0f7b302debc0d76e4ac7c9ac56: 8330066: HeapDumpPath and HeapDumpGzipLevel VM options do not mention HeapDumpBeforeFullGC and HeapDumpAfterFullGC
  • 7cff04fc8a8114a297437aa526b18b6185831eac: 8330276: Console methods with explicit Locale
  • ... and 92 more: https://git.openjdk.org/jdk/compare/8af606fb8cdb3a6ecdfe4cddd79f228b64d5fc80...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar May 16 '24 10:05 openjdk[bot]

@jaikiran @nizarbenalla Pushed as commit f9f8d0b48057a02923e36c8e11286b57cc72279e.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar May 16 '24 10:05 openjdk[bot]