8332096: hotspot-ide-project fails with this-escape

[alexmenkov]

The change fixes make hotspot-ide-project which fails with

\open\make\ide\visualstudio\hotspot\src\classes\build\tools\projectcreator\FileTreeCreator.java:54: warning: [this-escape] possible 'this' escape before subclass is fully initialized
      attributes.push(new DirAttributes());
                      ^
error: warnings found and -Werror specified 

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8332096: hotspot-ide-project fails with this-escape

Issue

• JDK-8332096: hotspot-ide-project fails with this-escape (Bug - P4)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19186/head:pull/19186
$ git checkout pull/19186

Update a local copy of the PR:
$ git checkout pull/19186
$ git pull https://git.openjdk.org/jdk.git pull/19186/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19186

View PR using the GUI difftool:
$ git pr show -t 19186

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19186.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332096: hotspot-ide-project fails with this-escape

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• abf54bb1e6da6d7bc432b3e9bb3ff164a895bd3e: 8332100: Add missing @since to KeyValue::EC_TYPE in java.xml.crypto
• 1484153c1a092cefc20270b35aa1e508280843a4: 8332080: Update troff man page for javadoc
• 391bbbc7d0fb95b0cd55e2f56c43bee019aeab7f: 8330584: IGV: XML does not save all node properties
• adaa509b6ed3d12569b8e5f2ec802cef22ab53c7: 8327499: MethodHandleStatics.traceLambdaForm includes methods that cannot be generated
• 5a8df4106ac5386eb72e874dcadf2b18defe27d8: 8331535: Incorrect prompt for Console.readLine
• 3e3f7cf4bddf243fddfeac8cfc1d9b2a1be55043: 8330387: Crash with a different types patterns (primitive vs generic) in instanceof
• d517d2df451e135583083ed3684d7d3241b36f76: 8331764: C2 SuperWord: refactor _align_to_ref/_mem_ref_for_main_loop_alignment
• 5053b70a7fc67ce9b73dbeecbdd88fbc34d45e04: 8278255: Add more warning text in ReentrantLock and ReentrantReadWriteLock
• 32c7681cf310c87669c502c4a8b62a7fecc93360: 8332029: Provide access to initial value of stderr via JavaLangAccess
• f9a1d3381b12c97784c11649be079147c85939c0: 8332020: jwebserver tool prints invalid URL in case of IPv6 address binding
• ... and 2 more: https://git.openjdk.org/jdk/compare/5e8e8ef6565e82a23626fe16893f93870dae1012...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk[bot]]

@alexmenkov The following labels will be automatically applied to this pull request:

• build
• ide-support

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 00: Full (41220d19)

[alexmenkov]

/integrate

[openjdk[bot]]

Going to push as commit 37c477856d543163b60dd2b85a5e6ac35a752211. Since your change was applied there have been 115 commits pushed to the master branch:

• 2170e99cb49a4ef2086ecec7515a72d56148d0f2: 8331081: 'internal proprietary API' diagnostics if --system is configured to an earlier JDK version
• a0c5714dbc8a60d905f9deea153e7f31fbd64d06: 8332071: Convert package.html files in java.management.rmi to package-info.java
• afed7d0b0593864e5595840a6b645c210ff28c7c: 8329538: Accelerate P256 on x86_64 using Montgomery intrinsic
• 9ca90ccd6bfec76e54e2e870bd706fad5abf233c: 8332610: Remove unused nWakeups in ObjectMonitor
• 92d33501e091bdfaab52886078053b849a5a8f68: 8331920: ubsan: g1CardSetContainers.inline.hpp:266:5: runtime error: index 2 out of bounds for type 'G1CardSetHowl::ContainerPtr [2]' reported
• 4f1a10f84bcfadef263a0890b6834ccd3d5bb52f: 8332360: JVM hangs at exit when running on a uniprocessor
• c3bc23fe48ca1603afe68a6ac4aaa523a1edbb41: 8326306: RISC-V: Re-structure MASM calls and jumps
• 8a9d77d58de259b6b2bdc2cc9e7bfdc28dcf7165: 8320622: [TEST] Improve coverage of compiler/loopopts/superword/TestMulAddS2I.java on different platforms
• 3d511ff63e59f542ae20c722bfef1c867cd1da0e: 8329748: Change default value of AssertWXAtThreadSync to true
• 67f03f2a4f5ac12748ffbf5c04f248a60869e180: 8332533: RISC-V: Enable vector variable shift instructions for machines with RVV
• ... and 105 more: https://git.openjdk.org/jdk/compare/5e8e8ef6565e82a23626fe16893f93870dae1012...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@alexmenkov Pushed as commit 37c477856d543163b60dd2b85a5e6ac35a752211.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.