jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8329748: Change default value of AssertWXAtThreadSync to true

Open tobiasholenstein opened this issue 9 months ago • 7 comments

The debug flag -XX:+AssertWXAtThreadSync conservatively checks for correct W^X thread state at possible safepoints or handshake. The flag is useful to detect missing MACOS_AARCH64_ONLY(ThreadWXEnable __wx(WXWrite, thread));. Since the check is cheap and it is a AARCH64_ONLY(develop(..)) only flag it makes sense to enable the flag by default.

There was one missing MACOS_AARCH64_ONLY(ThreadWXEnable __wx(WXWrite, thread)); to make all tests (tier1-7) pass.


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8329748: Change default value of AssertWXAtThreadSync to true (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19102/head:pull/19102
$ git checkout pull/19102

Update a local copy of the PR:
$ git checkout pull/19102
$ git pull https://git.openjdk.org/jdk.git pull/19102/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19102

View PR using the GUI difftool:
$ git pr show -t 19102

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19102.diff

Webrev

Link to Webrev Comment

tobiasholenstein avatar May 06 '24 11:05 tobiasholenstein