jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8321008: RISC-V: C2 MulAddVS2VI

Open Hamlin-Li opened this issue 10 months ago • 9 comments

Hi, Can you help to review the patch?

The motivation is to implement MulAddVS2VI. But to enable MulAddVS2VI, MulAddS2I is prerequisite, although MulAddS2I does not bring extra benefit on riscv as we don't have an specific instruction of muladd on riscv. So, this patch implement both MulAddVS2VI and MulAddS2I.

Thanks


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issues

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18919/head:pull/18919
$ git checkout pull/18919

Update a local copy of the PR:
$ git checkout pull/18919
$ git pull https://git.openjdk.org/jdk.git pull/18919/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18919

View PR using the GUI difftool:
$ git pr show -t 18919

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18919.diff

Webrev

Link to Webrev Comment

Hamlin-Li avatar Apr 23 '24 15:04 Hamlin-Li