jdk
jdk copied to clipboard
openjdk
8328285: GetOwnedMonitorInfo functions should use JvmtiHandshake
The JvmtiHandshake and JvmtiUnitedHandshakeClosure classes were introduced in the JDK 22 to unify/simplify the JVM TI functions supporting implementation of the virtual threads. This enhancement is to refactor JVM TI functions GetOwnedMonitorInfo and GetOwnedMonitorStackDepthInfo on the base of JvmtiHandshake and JvmtiUnitedHandshakeClosure` classes.
Testing:
- Ran mach5 tiers 1-6
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8328285: GetOwnedMonitorInfo functions should use JvmtiHandshake (Enhancement - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18332/head:pull/18332
$ git checkout pull/18332
Update a local copy of the PR:
$ git checkout pull/18332
$ git pull https://git.openjdk.org/jdk.git pull/18332/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18332
View PR using the GUI difftool:
$ git pr show -t 18332
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18332.diff
Webrev
:wave: Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@sspitsyn This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8328285: GetOwnedMonitorInfo functions should use JvmtiHandshake
Reviewed-by: pchilanomate, lmesnik
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 27 new commits pushed to the master branch:
- 43080173e88c8f53cd54c9096c79f3144007fd97: 8328631: Convert java/awt/InputMethods/InputMethodsTest/InputMethodsTest.java applet test to manual
- 700d2b91defd421a2818f53830c24f70d11ba4f6: 8328401: Convert java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.html applet test to automated
- bb3e84bd1fd8217fcb319de8a0716e44359e3423: 8328592: hprof tests fail with -XX:-CompactStrings
- ac2f8e5af8c88cd13038b113f82bb7c17a38aa40: 8327994: Update code gen in CallGeneratorHelper
- c434b79cff33e08e4518e92ddddae996dffefe29: 8327169: serviceability/dcmd/vm/SystemMapTest.java and SystemDumpMapTest.java may fail after JDK-8326586
- 700679011e5e9191f5170209454d35cc82953362: 8328628: JDK-8328157 incorrectly sets -MT on all compilers in jdk.jpackage
- 68170ae22233462e8925c75c4737be7f0ba9353d: 8328238: Convert few closed manual applet tests to main
- 9f5ad43358a4e209b4cd1c91bcc86b997f371548: 8320675: PrinterJob/SecurityDialogTest.java hangs
- 684678f9e83ed0a76541a31356894d170fd421db: 8328633: s390x: Improve vectorization of Match.sqrt() on floats
- 93d1700f23d42cb35b6028c5d7d029c035711acf: 8328589: unify os::breakpoint among posix platforms
- ... and 17 more: https://git.openjdk.org/jdk/compare/269163d509ec3c80983f55c5b47f472fa76be26c...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
@sspitsyn The following labels will be automatically applied to this pull request:
-
hotspot -
serviceability
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.
Webrevs
- 04: Full - Incremental (429e696a)
- 03: Full - Incremental (b7380b19)
- 02: Full - Incremental (ebbf0a0f)
- 01: Full - Incremental (78b7c894)
- 00: Full (a31c4f71)
Going to push as commit 4d36c4adcc47630ddc7149c48c06dc8a93c1be5c.
Since your change was applied there have been 46 commits pushed to the master branch:
- 0efd9dc09b969846f79fb8ca16ddf565117d52b6: 8328398: Convert java/awt/im/4490692/bug4490692.html applet test to main
- 46809b396ca76210f7939c8edf5a8263c29d3ddb: 8324736: Invalid end positions for EMPTY_STATEMENT
- f7f291c5d4d2d01dab3ccda7518ebc13f6bd58f6: 8328301: Convert Applet test ManualHTMLDataFlavorTest.java to main program
- 771f6a2f8e236e224b0e33b89f664c4bfc49e595: 8327704: Update nsk/jdi tests to use driver instead of othervm
- 4210e507a0e65de00fab50e0584aa82cd7b3bf27: 8320362: Load anchor certificates from Keychain keystore
- ab183e437c18b445e9c022a4d74de818d4ccecbe: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main
- ab28045d7785d948b2bce685f06043e8217961f4: 8328316: Finisher cannot emit if stream is sequential and integrator returned false
- ba05c6d0b6955a0c5110b75e709e2206961f9fec: 8328368: Convert java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet test to main
- fa823bd21c6676c67c42275efb59868200409b38: 8328540: test javax/swing/JSplitPane/4885629/bug4885629.java fails on windows hidpi
- e81374e0501a8201dac701824d2e29f2cedfcdff: 8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet
- ... and 36 more: https://git.openjdk.org/jdk/compare/269163d509ec3c80983f55c5b47f472fa76be26c...master
Your commit was automatically rebased without conflicts.
@sspitsyn Pushed as commit 4d36c4adcc47630ddc7149c48c06dc8a93c1be5c.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.