jdk
jdk copied to clipboard
openjdk
8328112: Remove CardTable::_guard_region
Hi all,
This patch removes the CardTable::_guard_region. Thanks for taking the time to review.
Best Regards, -- Guoxiong
Progress
- [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8328112: Remove CardTable::_guard_region (Enhancement - P4)
Reviewers
- Albert Mingkun Yang (@albertnetymk - Reviewer)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18324/head:pull/18324
$ git checkout pull/18324
Update a local copy of the PR:
$ git checkout pull/18324
$ git pull https://git.openjdk.org/jdk.git pull/18324/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18324
View PR using the GUI difftool:
$ git pr show -t 18324
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18324.diff
Webrev
:wave: Welcome back gli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@lgxbslgx This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8328112: Remove CardTable::_guard_region
Reviewed-by: tschatzl, ayang
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 25 new commits pushed to the master branch:
- 48717d63cc58f693f0917e61eafd672cd6af02ed: 8326333: jshell <TAB> completion on arrays is incomplete
- ece4124f25f676da9bf2d1b7fd8e4394dd7d31af: 8328247: Remove redundant dir for tests converted from applet to main
- d32ce65781c1d7815a69ceac720cdf3ae39caa9e: 8327651: Rename DictionaryEntry members related to protection domain
- 07194195cefc568048fa639b6f8534ce3718c8d2: 8328236: module_entry in CDS map file has stale value
- 0204aacb0305e94a7d6d5299a5ae835f3f71b030: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
- 9bc1b065db238b7c9d0562f9bd55d2f338c6ff3d: 8328242: Add a log area to the PassFailJFrame
- 65a84c2642822862fa186f290f8d6e83537bea06: 8328006: refactor large anonymous inner class in HtmlDocletWriter
- 044f4ed55dfce7f1aed9e10accf459b4af9b975e: 8326979: (jdeps) improve the error message for FindException caused by InvalidModuleDescriptorException
- 71f9c4e7fd5818be6e79dead3caa02d738456ad6: 8320534: fatal error for the NMTBenchmark test run for the mainline build
- bfba4894e14c9547735a6b4ae73ed423af09f0d4: 8328157: Move C[XX]FLAGS_JDK[LIB/EXE] to JdkNativeCompilation.gmk
- ... and 15 more: https://git.openjdk.org/jdk/compare/e8d1ba33b48dc8e6b937258c3765b91426c5b6f1...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
@lgxbslgx The following label will be automatically applied to this pull request:
hotspot-gc
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
Webrevs
- 03: Full - Incremental (95b56f14)
- 02: Full - Incremental (393c2e38)
- 01: Full - Incremental (c0a74704)
- 00: Full (4ff1b539)
Going to push as commit 3c70f26b2f3fa9bc143e2506af30f9b1daf20022.
Since your change was applied there have been 25 commits pushed to the master branch:
- 48717d63cc58f693f0917e61eafd672cd6af02ed: 8326333: jshell <TAB> completion on arrays is incomplete
- ece4124f25f676da9bf2d1b7fd8e4394dd7d31af: 8328247: Remove redundant dir for tests converted from applet to main
- d32ce65781c1d7815a69ceac720cdf3ae39caa9e: 8327651: Rename DictionaryEntry members related to protection domain
- 07194195cefc568048fa639b6f8534ce3718c8d2: 8328236: module_entry in CDS map file has stale value
- 0204aacb0305e94a7d6d5299a5ae835f3f71b030: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
- 9bc1b065db238b7c9d0562f9bd55d2f338c6ff3d: 8328242: Add a log area to the PassFailJFrame
- 65a84c2642822862fa186f290f8d6e83537bea06: 8328006: refactor large anonymous inner class in HtmlDocletWriter
- 044f4ed55dfce7f1aed9e10accf459b4af9b975e: 8326979: (jdeps) improve the error message for FindException caused by InvalidModuleDescriptorException
- 71f9c4e7fd5818be6e79dead3caa02d738456ad6: 8320534: fatal error for the NMTBenchmark test run for the mainline build
- bfba4894e14c9547735a6b4ae73ed423af09f0d4: 8328157: Move C[XX]FLAGS_JDK[LIB/EXE] to JdkNativeCompilation.gmk
- ... and 15 more: https://git.openjdk.org/jdk/compare/e8d1ba33b48dc8e6b937258c3765b91426c5b6f1...master
Your commit was automatically rebased without conflicts.
@lgxbslgx Pushed as commit 3c70f26b2f3fa9bc143e2506af30f9b1daf20022.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.