jdk icon indicating copy to clipboard operation
jdk copied to clipboard

Published 20 hours ago • verified publisher icon openjdk

8328244: Convert javax/swing/JSlider/6742358/bug6742358.java applet test to main

Open kumarabhi006 opened this issue 1 year ago • 4 comments
trafficstars

Conversion of manual applet test to main based using PassFailJFrame manual framework

Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8328244: Convert javax/swing/JSlider/6742358/bug6742358.java applet test to main (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18321/head:pull/18321
$ git checkout pull/18321

Update a local copy of the PR:
$ git checkout pull/18321
$ git pull https://git.openjdk.org/jdk.git pull/18321/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18321

View PR using the GUI difftool:
$ git pr show -t 18321

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18321.diff

Webrev

Link to Webrev Comment

kumarabhi006 avatar Mar 15 '24 05:03 kumarabhi006

:wave: Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Mar 15 '24 05:03 bridgekeeper[bot]

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328244: Convert javax/swing/JSlider/6742358/bug6742358.java applet test to main

Reviewed-by: psadhukhan, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 154 new commits pushed to the master branch:

  • c01095c0c9d4de1995d079be3356468196d9a25e: 8328262: Convert javax/swing/JSplitPane/8132123/bug8132123.java applet test to main
  • f1c69ccadb83306d1bb4860ff460a253af99643c: 8289822: G1: Make concurrent mark code owner of TAMSes
  • 5b6b514441fcbbaa210e2cad08ce2704fdf38191: 8325362: Allow to create a simple in-memory input JavaFileObject
  • c59c41aa6e28ab1dc59e6051f85e3e9ade251b07: 8326941: Remove StringUTF16::isBigEndian
  • 6eea5d675566adca3fca88639008c6c0221450a4: 8325187: JVMTI GetThreadState says virtual thread is JVMTI_THREAD_STATE_INTERRUPTED when it no longer is
  • 053ff76e14046f796f6e10a9cb2ede1f1ae22ed6: 8308660: C2 compilation hits 'node must be dead' assert
  • e1b0af29e47b46879defce1fc44c30d4d50d0c31: 8323972: C2 compilation fails with assert(!x->as_Loop()->is_loop_nest_inner_loop()) failed: loop was transformed
  • c0fc9563a707cb01db4baf3aebede5f6b3ea08d1: 8328275: CodeCache::print_internals should not be called in PRODUCT code
  • 4ef591f71f62ee6ea8a603ed7a3e568b348b2c16: 8326964: Remove Eclipse Shared Workspaces
  • ac5b6cb2d42bdb8fb1a110ad33411b50cff4ea61: 8327757: Convert javax/swing/JSlider/6524424/bug6524424.java applet to main
  • ... and 144 more: https://git.openjdk.org/jdk/compare/f2b5ffdb8ea3c766f14bab1dfd7c3865cffa2ce8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Mar 15 '24 05:03 openjdk[bot]

@kumarabhi006 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Mar 15 '24 05:03 openjdk[bot]

Webrevs

mlbridge[bot] avatar Mar 15 '24 05:03 mlbridge[bot]

/integrate

kumarabhi006 avatar Mar 19 '24 15:03 kumarabhi006

Going to push as commit 5f2a92d954ce485d372c3cb3e5118556b1d076c3. Since your change was applied there have been 156 commits pushed to the master branch:

  • 2094ff3c7ad829355bf13760d9a19b37649b3517: 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest test to main
  • db4842c9d9696af311762cb9c809952c55b34623: 8328364: Remove redundant fields in 'BOTConstants'
  • c01095c0c9d4de1995d079be3356468196d9a25e: 8328262: Convert javax/swing/JSplitPane/8132123/bug8132123.java applet test to main
  • f1c69ccadb83306d1bb4860ff460a253af99643c: 8289822: G1: Make concurrent mark code owner of TAMSes
  • 5b6b514441fcbbaa210e2cad08ce2704fdf38191: 8325362: Allow to create a simple in-memory input JavaFileObject
  • c59c41aa6e28ab1dc59e6051f85e3e9ade251b07: 8326941: Remove StringUTF16::isBigEndian
  • 6eea5d675566adca3fca88639008c6c0221450a4: 8325187: JVMTI GetThreadState says virtual thread is JVMTI_THREAD_STATE_INTERRUPTED when it no longer is
  • 053ff76e14046f796f6e10a9cb2ede1f1ae22ed6: 8308660: C2 compilation hits 'node must be dead' assert
  • e1b0af29e47b46879defce1fc44c30d4d50d0c31: 8323972: C2 compilation fails with assert(!x->as_Loop()->is_loop_nest_inner_loop()) failed: loop was transformed
  • c0fc9563a707cb01db4baf3aebede5f6b3ea08d1: 8328275: CodeCache::print_internals should not be called in PRODUCT code
  • ... and 146 more: https://git.openjdk.org/jdk/compare/f2b5ffdb8ea3c766f14bab1dfd7c3865cffa2ce8...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Mar 19 '24 15:03 openjdk[bot]

@kumarabhi006 Pushed as commit 5f2a92d954ce485d372c3cb3e5118556b1d076c3.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Mar 19 '24 15:03 openjdk[bot]