jdk
jdk copied to clipboard
8320794: Emulate rest of vblendvp[sd] on ECore
Replace vpblendvp[sd] with macro assembler call and test in:
-
C2_MacroAssembler::vector_cast_float_to_int_special_cases_avx
(insufficient registers for 1 of 2 blends) -
C2_MacroAssembler::vector_cast_double_to_int_special_cases_avx
-
C2_MacroAssembler::vector_count_leading_zeros_int_avx
Functional testing with existing and new tests:
make test TEST="test/hotspot/jtreg/compiler/vectorapi/reshape test/hotspot/jtreg/compiler/vectorization/runner/BasicIntOpTest.java"
Benchmarking with existing and new tests:
make test TEST="micro:org.openjdk.bench.jdk.incubator.vector.VectorFPtoIntCastOperations"
Performance before:
Benchmark (SIZE) Mode Cnt Score Error Units
VectorFPtoIntCastOperations.microDouble256ToInteger256 512 thrpt 5 17514.335 ± 145.342 ops/ms
VectorFPtoIntCastOperations.microDouble256ToInteger256 1024 thrpt 5 9525.645 ± 72.152 ops/ms
VectorFPtoIntCastOperations.microFloat256ToInteger256 512 thrpt 5 11684.992 ± 10.260 ops/ms
VectorFPtoIntCastOperations.microFloat256ToInteger256 1024 thrpt 5 6001.282 ± 7.813 ops/ms
VectorBitCount.WithSuperword.intLeadingZeroCount 1024 0 avgt 4 1002.290 ± 1.959 ns/op
Performance after:
Benchmark (SIZE) Mode Cnt Score Error Units
VectorFPtoIntCastOperations.microDouble256ToInteger256 512 thrpt 5 18241.190 ± 115.320 ops/ms
VectorFPtoIntCastOperations.microDouble256ToInteger256 1024 thrpt 5 9233.245 ± 123.493 ops/ms
VectorFPtoIntCastOperations.microFloat256ToInteger256 512 thrpt 5 11682.371 ± 5.806 ops/ms
VectorFPtoIntCastOperations.microFloat256ToInteger256 1024 thrpt 5 6006.308 ± 2.190 ops/ms
VectorBitCount.WithSuperword.intLeadingZeroCount 1024 0 avgt 4 957.081 ± 4.049 ns/op
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8320794: Emulate rest of vblendvp[sd] on ECore (Enhancement - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18310/head:pull/18310
$ git checkout pull/18310
Update a local copy of the PR:
$ git checkout pull/18310
$ git pull https://git.openjdk.org/jdk.git pull/18310/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18310
View PR using the GUI difftool:
$ git pr show -t 18310
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18310.diff
:wave: Welcome back vpaprotsk! A progress list of the required criteria for merging this PR into master
will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
@vpaprotsk The following label will be automatically applied to this pull request:
-
hotspot
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
Webrevs
- 03: Full - Incremental (0d3feee9)
- 02: Full - Incremental (1705a6aa)
- 01: Full - Incremental (9430d88e)
- 00: Full (af21bfc4)
@vpaprotsk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@vpaprotsk This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open
pull request command.