jdk
jdk copied to clipboard
openjdk
8328005: Convert java/awt/im/JTextFieldTest.java applet test to main
Convert java/awt/im/JTextFieldTest.java applet test to main using PassFailJFrame.
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8328005: Convert java/awt/im/JTextFieldTest.java applet test to main (Bug - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18247/head:pull/18247
$ git checkout pull/18247
Update a local copy of the PR:
$ git checkout pull/18247
$ git pull https://git.openjdk.org/jdk.git pull/18247/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18247
View PR using the GUI difftool:
$ git pr show -t 18247
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18247.diff
Webrev
:wave: Welcome back dnguyen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@DamonGuy The following label will be automatically applied to this pull request:
client
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
Webrevs
- 04: Full - Incremental (3aa7b0f2)
- 03: Full - Incremental (c27b6139)
- 02: Full - Incremental (e5f694ef)
- 01: Full - Incremental (9c1ceab9)
- 00: Full (4c2658c5)
@DamonGuy This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8328005: Convert java/awt/im/JTextFieldTest.java applet test to main
Reviewed-by: prr, abhiscxk
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 191 new commits pushed to the master branch:
- e66788c16563d343f6cccd2807a251ccc6f9b64a: 8325179: Race in BasicDirectoryModel.validateFileCache
- 1496b5de9004c6a9e43ead5f6e9e88362028a7cc: 8327924: Simplify TrayIconScalingTest.java
- 16ed191329b517766313761c8f3450b4a8285658: 8328101: Parallel: Obsolete ParallelOldDeadWoodLimiterMean and ParallelOldDeadWoodLimiterStdDev
- 581b1e29aebd425bade14d2ee46704a16187df5b: 8328402: Implement pausing functionality for the PassFailJFrame
- 75195aab497a2d23548128e03f6887283dcaa7e1: 8328299: Convert DnDFileGroupDescriptor.html applet test to main
- 725d87bbc2abae2ca856d91668f0a494f93fca1c: 8328570: Convert closed JViewport manual applet tests to main
- e41bc42deb22615c9b93ee639d04e9ed2bd57f64: 8327990: [macosx-aarch64] Various tests fail with -XX:+AssertWXAtThreadSync
- 43080173e88c8f53cd54c9096c79f3144007fd97: 8328631: Convert java/awt/InputMethods/InputMethodsTest/InputMethodsTest.java applet test to manual
- 700d2b91defd421a2818f53830c24f70d11ba4f6: 8328401: Convert java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.html applet test to automated
- bb3e84bd1fd8217fcb319de8a0716e44359e3423: 8328592: hprof tests fail with -XX:-CompactStrings
- ... and 181 more: https://git.openjdk.org/jdk/compare/c65d308973f1e2c41b6910fd844223597e70972f...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
Going to push as commit cc5cda558736ffeae2a4611d87dfe280b9a4eac3.
Since your change was applied there have been 192 commits pushed to the master branch:
- ef2bd5721316f208a458fecfffa02ec2c0ea7fe0: 8328558: Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main
- e66788c16563d343f6cccd2807a251ccc6f9b64a: 8325179: Race in BasicDirectoryModel.validateFileCache
- 1496b5de9004c6a9e43ead5f6e9e88362028a7cc: 8327924: Simplify TrayIconScalingTest.java
- 16ed191329b517766313761c8f3450b4a8285658: 8328101: Parallel: Obsolete ParallelOldDeadWoodLimiterMean and ParallelOldDeadWoodLimiterStdDev
- 581b1e29aebd425bade14d2ee46704a16187df5b: 8328402: Implement pausing functionality for the PassFailJFrame
- 75195aab497a2d23548128e03f6887283dcaa7e1: 8328299: Convert DnDFileGroupDescriptor.html applet test to main
- 725d87bbc2abae2ca856d91668f0a494f93fca1c: 8328570: Convert closed JViewport manual applet tests to main
- e41bc42deb22615c9b93ee639d04e9ed2bd57f64: 8327990: [macosx-aarch64] Various tests fail with -XX:+AssertWXAtThreadSync
- 43080173e88c8f53cd54c9096c79f3144007fd97: 8328631: Convert java/awt/InputMethods/InputMethodsTest/InputMethodsTest.java applet test to manual
- 700d2b91defd421a2818f53830c24f70d11ba4f6: 8328401: Convert java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.html applet test to automated
- ... and 182 more: https://git.openjdk.org/jdk/compare/c65d308973f1e2c41b6910fd844223597e70972f...master
Your commit was automatically rebased without conflicts.
@DamonGuy Pushed as commit cc5cda558736ffeae2a4611d87dfe280b9a4eac3.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.