jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8327980: Convert javax/swing/JToggleButton/4128979/bug4128979.java applet test to main

Open kumarabhi006 opened this issue 1 year ago • 5 comments
trafficstars

Conversion of manual applet test to main based using PassFailJFrame manual framework


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8327980: Convert javax/swing/JToggleButton/4128979/bug4128979.java applet test to main (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18233/head:pull/18233
$ git checkout pull/18233

Update a local copy of the PR:
$ git checkout pull/18233
$ git pull https://git.openjdk.org/jdk.git pull/18233/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18233

View PR using the GUI difftool:
$ git pr show -t 18233

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18233.diff

Webrev

Link to Webrev Comment

kumarabhi006 avatar Mar 12 '24 12:03 kumarabhi006

:wave: Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Mar 12 '24 12:03 bridgekeeper[bot]

@kumarabhi006 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Mar 12 '24 12:03 openjdk[bot]

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327980: Convert javax/swing/JToggleButton/4128979/bug4128979.java applet test to main

Reviewed-by: honkar, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 212 new commits pushed to the master branch:

  • 4d36c4adcc47630ddc7149c48c06dc8a93c1be5c: 8328285: GetOwnedMonitorInfo functions should use JvmtiHandshake
  • 0efd9dc09b969846f79fb8ca16ddf565117d52b6: 8328398: Convert java/awt/im/4490692/bug4490692.html applet test to main
  • 46809b396ca76210f7939c8edf5a8263c29d3ddb: 8324736: Invalid end positions for EMPTY_STATEMENT
  • f7f291c5d4d2d01dab3ccda7518ebc13f6bd58f6: 8328301: Convert Applet test ManualHTMLDataFlavorTest.java to main program
  • 771f6a2f8e236e224b0e33b89f664c4bfc49e595: 8327704: Update nsk/jdi tests to use driver instead of othervm
  • 4210e507a0e65de00fab50e0584aa82cd7b3bf27: 8320362: Load anchor certificates from Keychain keystore
  • ab183e437c18b445e9c022a4d74de818d4ccecbe: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main
  • ab28045d7785d948b2bce685f06043e8217961f4: 8328316: Finisher cannot emit if stream is sequential and integrator returned false
  • ba05c6d0b6955a0c5110b75e709e2206961f9fec: 8328368: Convert java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet test to main
  • fa823bd21c6676c67c42275efb59868200409b38: 8328540: test javax/swing/JSplitPane/4885629/bug4885629.java fails on windows hidpi
  • ... and 202 more: https://git.openjdk.org/jdk/compare/f2b5ffdb8ea3c766f14bab1dfd7c3865cffa2ce8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Mar 13 '24 20:03 openjdk[bot]

@honkar-jdk Updated as per last review. Please take a look.

kumarabhi006 avatar Mar 14 '24 16:03 kumarabhi006

@honkar-jdk Please take a look.

kumarabhi006 avatar Mar 18 '24 11:03 kumarabhi006

@honkar-jdk @TejeshR13 Test is updated. Please take a look.

kumarabhi006 avatar Mar 21 '24 07:03 kumarabhi006

/integrate

kumarabhi006 avatar Mar 22 '24 03:03 kumarabhi006

Going to push as commit 256d48b19694e86bb26d67ed56de8ac94a31f4ff. Since your change was applied there have been 214 commits pushed to the master branch:

  • 177b8a241c11782b302607c0068b15b38112e67c: 8327840: Automate javax/swing/border/Test4129681.java
  • da009214f19f73965495b8462c9dcff5db8ae7ae: 8320404: Double whitespace in SubTypeCheckNode::dump_spec output
  • 4d36c4adcc47630ddc7149c48c06dc8a93c1be5c: 8328285: GetOwnedMonitorInfo functions should use JvmtiHandshake
  • 0efd9dc09b969846f79fb8ca16ddf565117d52b6: 8328398: Convert java/awt/im/4490692/bug4490692.html applet test to main
  • 46809b396ca76210f7939c8edf5a8263c29d3ddb: 8324736: Invalid end positions for EMPTY_STATEMENT
  • f7f291c5d4d2d01dab3ccda7518ebc13f6bd58f6: 8328301: Convert Applet test ManualHTMLDataFlavorTest.java to main program
  • 771f6a2f8e236e224b0e33b89f664c4bfc49e595: 8327704: Update nsk/jdi tests to use driver instead of othervm
  • 4210e507a0e65de00fab50e0584aa82cd7b3bf27: 8320362: Load anchor certificates from Keychain keystore
  • ab183e437c18b445e9c022a4d74de818d4ccecbe: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main
  • ab28045d7785d948b2bce685f06043e8217961f4: 8328316: Finisher cannot emit if stream is sequential and integrator returned false
  • ... and 204 more: https://git.openjdk.org/jdk/compare/f2b5ffdb8ea3c766f14bab1dfd7c3865cffa2ce8...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Mar 22 '24 03:03 openjdk[bot]

@kumarabhi006 Pushed as commit 256d48b19694e86bb26d67ed56de8ac94a31f4ff.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Mar 22 '24 03:03 openjdk[bot]