jdk
jdk copied to clipboard
8327796: Add method to java.net.http.HttpRequest to return a GET request in one call
Hi,
This PR proposes to add simple utility method which returns a simple GET HttpRequest in one call. The current builder pattern requires 4 (or 3 since GET is the default method) method calls to achieve the same effect.
Thanks, Michael
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] Change requires a CSR request matching fixVersion 23 to be approved (needs to be created)
Issue
- JDK-8327796: Add method to java.net.http.HttpRequest to return a GET request in one call (Bug - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18227/head:pull/18227
$ git checkout pull/18227
Update a local copy of the PR:
$ git checkout pull/18227
$ git pull https://git.openjdk.org/jdk.git pull/18227/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18227
View PR using the GUI difftool:
$ git pr show -t 18227
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18227.diff
Webrev
:wave: Welcome back michaelm! A progress list of the required criteria for merging this PR into master
will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@Michael-Mc-Mahon The following label will be automatically applied to this pull request:
-
net
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
/csr needed
@Michael-Mc-Mahon has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@Michael-Mc-Mahon please create a CSR request for issue JDK-8327796 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.
Webrevs
- 04: Full - Incremental (62b71bc8)
- 03: Full - Incremental (e7a7f213)
- 02: Full - Incremental (a691e2cf)
- 01: Full - Incremental (2de260e5)
- 00: Full (b27db570)
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
@Michael-Mc-Mahon This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@Michael-Mc-Mahon This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open
pull request command.