jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8327945: Inline HasScavengableOops

Open albertnetymk opened this issue 11 months ago • 4 comments

Trivial inlining a class to reduce its visibility.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8327945: Inline HasScavengableOops (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18223/head:pull/18223
$ git checkout pull/18223

Update a local copy of the PR:
$ git checkout pull/18223
$ git pull https://git.openjdk.org/jdk.git pull/18223/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18223

View PR using the GUI difftool:
$ git pr show -t 18223

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18223.diff

Webrev

Link to Webrev Comment

albertnetymk avatar Mar 12 '24 08:03 albertnetymk

:wave: Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Mar 12 '24 08:03 bridgekeeper[bot]

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Mar 12 '24 08:03 openjdk[bot]

Webrevs

mlbridge[bot] avatar Mar 12 '24 08:03 mlbridge[bot]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327945: Inline HasScavengableOops

Reviewed-by: gli, aboldtch

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • fb390d202c8bbbbb87ba48fd01387feb35a1b768: 8327839: Crash with unboxing and widening primitive conversion in switch
  • 86f17447362483162a5983c270e0b530d8d99354: 8328248: Convert javax/swing/JSlider/6587742/bug6587742.java applet test to main
  • 7baec6622254fc21e315b974a213605a7605daac: 8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Mar 13 '24 20:03 openjdk[bot]

@albertnetymk Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

openjdk[bot] avatar Mar 18 '24 10:03 openjdk[bot]

Thanks for review.

/integrate

albertnetymk avatar Mar 18 '24 13:03 albertnetymk

Going to push as commit f3af91815a662b195938b26962a8670a4a692220. Since your change was applied there have been 3 commits pushed to the master branch:

  • fb390d202c8bbbbb87ba48fd01387feb35a1b768: 8327839: Crash with unboxing and widening primitive conversion in switch
  • 86f17447362483162a5983c270e0b530d8d99354: 8328248: Convert javax/swing/JSlider/6587742/bug6587742.java applet test to main
  • 7baec6622254fc21e315b974a213605a7605daac: 8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Mar 18 '24 13:03 openjdk[bot]

@albertnetymk Pushed as commit f3af91815a662b195938b26962a8670a4a692220.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Mar 18 '24 13:03 openjdk[bot]