jdk
jdk copied to clipboard
openjdk
8327818: Implement Kerberos debug with sun.security.util.Debug
Change Krb5LoginModule debugging to use sun.security.util.Debug.
Progress
- [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [x] Change requires CSR request JDK-8327830 to be approved
Issues
- JDK-8327818: Implement Kerberos debug with sun.security.util.Debug (Enhancement - P4)
- JDK-8327830: Implement Kerberos debug with sun.security.util.Debug (CSR)
Reviewers
- Sean Coffey (@coffeys - Reviewer)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18199/head:pull/18199
$ git checkout pull/18199
Update a local copy of the PR:
$ git checkout pull/18199
$ git pull https://git.openjdk.org/jdk.git pull/18199/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18199
View PR using the GUI difftool:
$ git pr show -t 18199
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18199.diff
Webrev
:wave: Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@wangweij The following label will be automatically applied to this pull request:
-
security
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
Webrevs
- 08: Full - Incremental (01bb32c4)
- 07: Full - Incremental (94d0b4ea)
- 06: Full - Incremental (3491a4c7)
- 05: Full - Incremental (a89d3589)
- 04: Full - Incremental (c877d7be)
- 03: Full - Incremental (b63deeba)
- 02: Full - Incremental (25cf73c3)
- 01: Full - Incremental (46dcb685)
- 00: Full (fef55d28)
@wangweij This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8327818: Implement Kerberos debug with sun.security.util.Debug
Reviewed-by: coffeys, ssahoo
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 136 new commits pushed to the master branch:
- c342188fd978dd94e7788fb0fb0345fd8c0eaa9a: 8328074: Add jcheck whitespace checking for assembly files
- 3c70f26b2f3fa9bc143e2506af30f9b1daf20022: 8328112: Remove CardTable::_guard_region
- 48717d63cc58f693f0917e61eafd672cd6af02ed: 8326333: jshell <TAB> completion on arrays is incomplete
- ece4124f25f676da9bf2d1b7fd8e4394dd7d31af: 8328247: Remove redundant dir for tests converted from applet to main
- d32ce65781c1d7815a69ceac720cdf3ae39caa9e: 8327651: Rename DictionaryEntry members related to protection domain
- 07194195cefc568048fa639b6f8534ce3718c8d2: 8328236: module_entry in CDS map file has stale value
- 0204aacb0305e94a7d6d5299a5ae835f3f71b030: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
- 9bc1b065db238b7c9d0562f9bd55d2f338c6ff3d: 8328242: Add a log area to the PassFailJFrame
- 65a84c2642822862fa186f290f8d6e83537bea06: 8328006: refactor large anonymous inner class in HtmlDocletWriter
- 044f4ed55dfce7f1aed9e10accf459b4af9b975e: 8326979: (jdeps) improve the error message for FindException caused by InvalidModuleDescriptorException
- ... and 126 more: https://git.openjdk.org/jdk/compare/a6dc4bc2b83c7240e573ac43f9b7a10191c58ed3...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
A new commit is pushed to cover all other debug outpus in JGSS/krb5. Most of the changes are simply one of:
-
if (DEBUG)/toif (DEBUG != null) -
System.out.printlntoDEBUG.println. -
e.printStackTrace(System.out)toe.printStackTrace(DEBUG.getPrintStream())
There is no more DEBUG = Krb5.DEBUG assignments. Always use import static Krb5.DEBUG.
Going to push as commit 569b05addf69698fc93026b4dca69bc6ca0920b6.
Since your change was applied there have been 143 commits pushed to the master branch:
- dec68d7e36a9436468594416272c44a2afbece8d: 8328234: Remove unused nativeUtils files
- 7734466c4627c51b2c24b4b4dbf6db4184607aa3: 8325871: Move StringTable and SymbolTable rehashing calls
- 9e98118f289e98ca9f3be2a274e0ddf8822aaa7c: 8328177: Move LDFLAGS_JDK[LIB/EXE] to JdkNativeCompilation.gmk
- f3af91815a662b195938b26962a8670a4a692220: 8327945: Inline HasScavengableOops
- fb390d202c8bbbbb87ba48fd01387feb35a1b768: 8327839: Crash with unboxing and widening primitive conversion in switch
- 86f17447362483162a5983c270e0b530d8d99354: 8328248: Convert javax/swing/JSlider/6587742/bug6587742.java applet test to main
- 7baec6622254fc21e315b974a213605a7605daac: 8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size
- c342188fd978dd94e7788fb0fb0345fd8c0eaa9a: 8328074: Add jcheck whitespace checking for assembly files
- 3c70f26b2f3fa9bc143e2506af30f9b1daf20022: 8328112: Remove CardTable::_guard_region
- 48717d63cc58f693f0917e61eafd672cd6af02ed: 8326333: jshell <TAB> completion on arrays is incomplete
- ... and 133 more: https://git.openjdk.org/jdk/compare/a6dc4bc2b83c7240e573ac43f9b7a10191c58ed3...master
Your commit was automatically rebased without conflicts.
@wangweij Pushed as commit 569b05addf69698fc93026b4dca69bc6ca0920b6.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.