8327182: Move serverAlias into the loop

[johnshajiang]

trafficstars

In method X509Authentication::createServerPossession, it looks unnecessary to define variable serverAlias out of the for-loop. It may be better to move serverAlias into that loop to narrow down the scope.

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8327182: Move serverAlias into the loop (Bug - P4)

Reviewers

• Guoxiong Li (@lgxbslgx - Committer) ⚠️ Review applies to 8e889cba
• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18100/head:pull/18100
$ git checkout pull/18100

Update a local copy of the PR:
$ git checkout pull/18100
$ git pull https://git.openjdk.org/jdk.git pull/18100/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18100

View PR using the GUI difftool:
$ git pr show -t 18100

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18100.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back jjiang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@johnshajiang The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 01: Full (8ceabf7c)
• 00: Full (8e889cba)

[openjdk[bot]]

@johnshajiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327182: Move serverAlias into the loop

Reviewed-by: gli, mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

• c342188fd978dd94e7788fb0fb0345fd8c0eaa9a: 8328074: Add jcheck whitespace checking for assembly files
• 3c70f26b2f3fa9bc143e2506af30f9b1daf20022: 8328112: Remove CardTable::_guard_region
• 48717d63cc58f693f0917e61eafd672cd6af02ed: 8326333: jshell <TAB> completion on arrays is incomplete
• ece4124f25f676da9bf2d1b7fd8e4394dd7d31af: 8328247: Remove redundant dir for tests converted from applet to main
• d32ce65781c1d7815a69ceac720cdf3ae39caa9e: 8327651: Rename DictionaryEntry members related to protection domain
• 07194195cefc568048fa639b6f8534ce3718c8d2: 8328236: module_entry in CDS map file has stale value
• 0204aacb0305e94a7d6d5299a5ae835f3f71b030: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
• 9bc1b065db238b7c9d0562f9bd55d2f338c6ff3d: 8328242: Add a log area to the PassFailJFrame
• 65a84c2642822862fa186f290f8d6e83537bea06: 8328006: refactor large anonymous inner class in HtmlDocletWriter
• 044f4ed55dfce7f1aed9e10accf459b4af9b975e: 8326979: (jdeps) improve the error message for FindException caused by InvalidModuleDescriptorException
• ... and 54 more: https://git.openjdk.org/jdk/compare/98e4b753e8d7fbbf651c866901734d4f6a7d1680...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[johnshajiang]

@seanjmullan Thanks for your review!

Did you run all JSSE security regression tests?

I did run all tests in javax/net/ssl and sun/security/ssl, and they passed.

[johnshajiang]

/integrate

[openjdk[bot]]

Going to push as commit 9059727df135dc90311bd476124f090b5766092b. Since your change was applied there have been 78 commits pushed to the master branch:

• 2dd5fba3bd37c577b8442b67a67dbcb22b9a530e: 8319889: Vector API tests trigger VM crashes with -XX:+StressIncrementalInlining
• 3f2e849c54c2a9c55e3b5c9f5a6d3478b83144e3: 8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed."
• c901da48e30d53cb8e4e3c1f0584c5f2d3d095f1: 8327098: GTest needs larger combination limit
• 9e32db266e4c3cc9be273fa6b77112832a43ba4a: 8328309: Remove malformed masked shift instruction selection patterns
• fc0472baf9bad298e853bf2ca3d10dc9415272cd: 8328000: Convert /java/awt/im/8154816/bug8154816.java applet test to main
• 85fc47c81af81a595dc88e61454d8ba2d860f301: 8327180: Failed: java/io/ObjectStreamClass/ObjectStreamClassCaching.java#G1
• 569b05addf69698fc93026b4dca69bc6ca0920b6: 8327818: Implement Kerberos debug with sun.security.util.Debug
• dec68d7e36a9436468594416272c44a2afbece8d: 8328234: Remove unused nativeUtils files
• 7734466c4627c51b2c24b4b4dbf6db4184607aa3: 8325871: Move StringTable and SymbolTable rehashing calls
• 9e98118f289e98ca9f3be2a274e0ddf8822aaa7c: 8328177: Move LDFLAGS_JDK[LIB/EXE] to JdkNativeCompilation.gmk
• ... and 68 more: https://git.openjdk.org/jdk/compare/98e4b753e8d7fbbf651c866901734d4f6a7d1680...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@johnshajiang Pushed as commit 9059727df135dc90311bd476124f090b5766092b.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.