jdk icon indicating copy to clipboard operation
jdk copied to clipboard

Add intrinsic for new method System.myTrap

Open adinn opened this issue 1 year ago • 3 comments
trafficstars

This PR is not for integration. It is provided to showcase example code, provided by @theRealAph, that implements an intrinsic for a Java native method and uses it as a debugging aid.

The patch modifies a few locations in the JDK to invoke the intrinsic. gdb can be used to break when the intrinsic implementation is called, allowing the user to view the Java stack or return in order to step through interpreter or compiled code.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [ ] Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17730/head:pull/17730
$ git checkout pull/17730

Update a local copy of the PR:
$ git checkout pull/17730
$ git pull https://git.openjdk.org/jdk.git pull/17730/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17730

View PR using the GUI difftool:
$ git pr show -t 17730

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17730.diff

adinn avatar Feb 06 '24 11:02 adinn

:wave: Welcome back adinn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Feb 06 '24 11:02 bridgekeeper[bot]

@adinn The following labels will be automatically applied to this pull request:

  • build
  • core-libs
  • hotspot
  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Feb 06 '24 11:02 openjdk[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Mar 13 '24 20:03 openjdk[bot]

@adinn This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar May 08 '24 22:05 bridgekeeper[bot]

@adinn This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Jul 04 '24 01:07 bridgekeeper[bot]