8323634: Shenandoah: Document behavior of EvacOOM protocol

[kdnilsen]

The protocol for handling OOM during evacuation is subtle and critical for correct operation. This PR does NOT change behavior. It provides improved documentation of existing behavior.

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8323634: Shenandoah: Document behavior of EvacOOM protocol (Bug - P5)

Reviewers

• William Kemper (@earthling-amzn - Committer) ⚠️ Review applies to d1d1c1c6
• Y. Srinivas Ramakrishna (@ysramakrishna - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17385/head:pull/17385
$ git checkout pull/17385

Update a local copy of the PR:
$ git checkout pull/17385
$ git pull https://git.openjdk.org/jdk.git pull/17385/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17385

View PR using the GUI difftool:
$ git pr show -t 17385

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17385.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back kdnilsen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@kdnilsen The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 04: Full - Incremental (6017ea1c)
• 03: Full - Incremental (d1d1c1c6)
• 02: Full - Incremental (23e0d4b4)
• 01: Full - Incremental (8f31b884)
• 00: Full (1e3a07ca)

[kdnilsen]

/integrate

[openjdk[bot]]

@kdnilsen This pull request has not yet been marked as ready for integration.

[openjdk[bot]]

@kdnilsen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323634: Shenandoah: Document behavior of EvacOOM protocol

Reviewed-by: wkemper, ysr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1178 new commits pushed to the master branch:

• 70944ca54ad0090c734bb5b3082beb33450c4877: 8330033: com/sun/net/httpserver/bugs/B6431193.java fails in AssertionError after JDK-8326568
• 279ed0ddd505fb3052b818f755b4b220ed5557e6: 8329961: Buffer overflow in os::Linux::kernel_version
• 9731b1c8b02d957985f4fb40acd93fb67747a9f0: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel
• c5150c7b81e2b7b8c9e13c228d3b7bcb9dfe5024: 8309751: Duplicate constant pool entries added during default method processing
• 86cb76728dd164faa8fe69cd07db85977e79be29: 8326568: jdk/test/com/sun/net/httpserver/bugs/B6431193.java should use try-with-resource and try-finally
• b49ba426a721db5926ac1b45d573d468389d479c: 8330002: Remove redundant public keyword in BarrierSet
• dd6e4533eb8b9c33b03a041d7a9ac87160ff9ffb: 8329767: G1: Move G1BlockOffsetTable::set_for_starts_humongous to HeapRegion
• e0fd6c4c9e30ef107ea930c8ecc449842ae4b8d4: 8329545: [s390x] Fix garbage value being passed in Argument Register
• 51ed69a586105b707ae616f9eba898449bf9fba7: 8327621: Check return value of uname in os::get_host_name
• bea9acc55a7b0463a1b0b4dcb557f8ea17d8fe8c: 8328482: Convert and Open source few manual applet test to main based
• ... and 1168 more: https://git.openjdk.org/jdk/compare/93bedd7abae33f5d5eb909d3d216ee415ad2f8b2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@earthling-amzn, @ysramakrishna, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[shipilev]

Hm, I expected that "Document behavior" would only change comments, but I also see code additions. Let me look at the whole thing. I think I have a few editorial comments as well, I'll just give a patch on top of this PR.

[bridgekeeper[bot]]

@kdnilsen This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@kdnilsen This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.