jdk icon indicating copy to clipboard operation
jdk copied to clipboard

JDK-8293412 Remove unnecessary java.security.egd overrides

Open mcpowers opened this issue 2 years ago • 2 comments

https://bugs.openjdk.org/browse/JDK-8293412


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8293412: Remove unnecessary java.security.egd overrides

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10716/head:pull/10716
$ git checkout pull/10716

Update a local copy of the PR:
$ git checkout pull/10716
$ git pull https://git.openjdk.org/jdk pull/10716/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10716

View PR using the GUI difftool:
$ git pr show -t 10716

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10716.diff

mcpowers avatar Oct 14 '22 21:10 mcpowers

:wave: Welcome back mpowers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Oct 14 '22 21:10 bridgekeeper[bot]

@mcpowers The following labels will be automatically applied to this pull request:

  • core-libs
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Oct 14 '22 21:10 openjdk[bot]

No failures were noticed during mach5 and jtreg testing.

mcpowers avatar Oct 28 '22 22:10 mcpowers

Webrevs

mlbridge[bot] avatar Oct 29 '22 02:10 mlbridge[bot]

@mcpowers This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293412: Remove unnecessary java.security.egd overrides

Reviewed-by: xuelei, djelinski

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

  • ea83cb960d07ffa9384aad6a1e2a0233e3ebbdd1: 8297450: ScaledTextFieldBorderTest.java fails when run with -show parameter
  • 336d230a39e41eeed8b9d2ce3fec42e9de1d11fe: 8297958: NMT: Display peak values
  • 0d2a9ee5287779c2e33fc0bfda84aa6128d8f479: 8298142: Update internal comment on language features in SourceVersion
  • 203251ffc0ea8b9bb9c8b95c50434e4185020d84: 8297379: Enable the ByteBuffer path of Poly1305 optimizations
  • 1e468320dc6e495343dbdf392cbcbda79672c7ad: 8297602: Compiler crash with type annotation and generic record during pattern matching
  • b0e54328c530faf8aae2f48a37ff378215142689: 8297687: new URI(S,S,S,S) throws exception with incorrect index position reported in the error message
  • 2243646fe35226e6d12d478483264270537a83cc: 8298145: Remove ContiguousSpace::capacity
  • 84b927a05bcb7bf32a12829070ffd3a5670066d2: 8296024: Usage of DirectBuffer::address should be guarded
  • a9e6c62ba7df8d28cef9579c57a0386736bd9dbf: 8297186: G1 triggers unnecessary full GCs when heap utilization is low
  • 4458de95f845c036c1c8e28df7043e989beaee98: 8297172: Fix some issues of auto-vectorization of Long.bitCount/numberOfTrailingZeros/numberOfLeadingZeros()
  • ... and 48 more: https://git.openjdk.org/jdk/compare/2821fa9883cc9687b53e3bb5655732a614cff8fc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@XueleiFan, @djelinski) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar Oct 29 '22 04:10 openjdk[bot]

/label remove core-libs

AlanBateman avatar Oct 29 '22 06:10 AlanBateman

@AlanBateman The core-libs label was successfully removed.

openjdk[bot] avatar Oct 29 '22 06:10 openjdk[bot]

Verified with testing that /dev/urandom is used when overrides are removed from Compatibility.java and SecurityTools.java.

mcpowers avatar Nov 22 '22 22:11 mcpowers

/integrate

mcpowers avatar Dec 06 '22 20:12 mcpowers

@mcpowers Your change (at version 8076b616b405d14f7b72dca987fc3c1859aed39f) is now ready to be sponsored by a Committer.

openjdk[bot] avatar Dec 06 '22 20:12 openjdk[bot]

/sponsor

wangweij avatar Dec 06 '22 20:12 wangweij

Going to push as commit 79d163d4994d235266117b425498b0df3d16c3c4. Since your change was applied there have been 58 commits pushed to the master branch:

  • ea83cb960d07ffa9384aad6a1e2a0233e3ebbdd1: 8297450: ScaledTextFieldBorderTest.java fails when run with -show parameter
  • 336d230a39e41eeed8b9d2ce3fec42e9de1d11fe: 8297958: NMT: Display peak values
  • 0d2a9ee5287779c2e33fc0bfda84aa6128d8f479: 8298142: Update internal comment on language features in SourceVersion
  • 203251ffc0ea8b9bb9c8b95c50434e4185020d84: 8297379: Enable the ByteBuffer path of Poly1305 optimizations
  • 1e468320dc6e495343dbdf392cbcbda79672c7ad: 8297602: Compiler crash with type annotation and generic record during pattern matching
  • b0e54328c530faf8aae2f48a37ff378215142689: 8297687: new URI(S,S,S,S) throws exception with incorrect index position reported in the error message
  • 2243646fe35226e6d12d478483264270537a83cc: 8298145: Remove ContiguousSpace::capacity
  • 84b927a05bcb7bf32a12829070ffd3a5670066d2: 8296024: Usage of DirectBuffer::address should be guarded
  • a9e6c62ba7df8d28cef9579c57a0386736bd9dbf: 8297186: G1 triggers unnecessary full GCs when heap utilization is low
  • 4458de95f845c036c1c8e28df7043e989beaee98: 8297172: Fix some issues of auto-vectorization of Long.bitCount/numberOfTrailingZeros/numberOfLeadingZeros()
  • ... and 48 more: https://git.openjdk.org/jdk/compare/2821fa9883cc9687b53e3bb5655732a614cff8fc...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Dec 06 '22 20:12 openjdk[bot]

@wangweij @mcpowers Pushed as commit 79d163d4994d235266117b425498b0df3d16c3c4.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Dec 06 '22 20:12 openjdk[bot]