jdk icon indicating copy to clipboard operation
jdk copied to clipboard

Published 20 hours ago • verified publisher icon openjdk

8295239: Refactor java/util/Formatter/Basic script into a Java native test launcher

Open justin-curtis-lu opened this issue 2 years ago • 2 comments

Issue: Formatter unit tests are launched via basic.sh

Fix: Replace basic.sh with a Java test launcher

Note: Java.internal.math was included in the original configuration of Basic, but I removed it as it was not used within the Basic unit tests

Original output on success

New output on success

Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8295239: Refactor java/util/Formatter/Basic script into a Java native test launcher

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10715/head:pull/10715
$ git checkout pull/10715

Update a local copy of the PR:
$ git checkout pull/10715
$ git pull https://git.openjdk.org/jdk pull/10715/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10715

View PR using the GUI difftool:
$ git pr show -t 10715

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10715.diff

justin-curtis-lu avatar Oct 14 '22 20:10 justin-curtis-lu

:wave: Welcome back justin-curtis-lu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Oct 14 '22 20:10 bridgekeeper[bot]

@justin-curtis-lu The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Oct 14 '22 20:10 openjdk[bot]

Webrevs

mlbridge[bot] avatar Oct 17 '22 22:10 mlbridge[bot]

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295239: Refactor java/util/Formatter/Basic script into a Java native test launcher

Reviewed-by: lancea, bchristi, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 141 new commits pushed to the master branch:

  • f5dabf94400b0a6082bc2eaf3ff33a11a36ad138: 8295088: Update External Spec page to show tabs for hosts
  • 218104247e2ae26ad8221f4dd78be1170b952be0: 8295375: debug agent class tracking should not piggy back on the cbClassPrepare() callback
  • f41711ef63d1a14392bf5e5b9ae6939f8772e803: 8295650: JFR: jfr scrub should warn if an event type doesn't exist
  • 0c13d66622a8c2be654bb867aa8c17421d1557ca: 8295530: Update Zlib Data Compression Library to Version 1.2.13
  • 15bebf922fb3fe46b755c85bc0a459b3c1e34c98: 8295666: Linux x86 build fails after 8292591
  • 50647187e8b0314ad67b0767f71c56fd50e8feaf: 8294460: CodeSection::alignment checks for CodeBuffer::SECT_STUBS incorrectly
  • 8b010e014c44ffb728b7a8343d3298466f5252fa: 8030616: sun/management/jmxremote/bootstrap/RmiBootstrapTest fails intermittently with cannot find a free port
  • b35922be6de7b848a2982d6a278dbd205fc39e6a: 8295714: GHA ::set-output is deprecated and will be removed
  • dfd2d83144fe4d78a7144acda6d9cb3e0045ea70: 8295657: SA: Allow larger object alignments
  • a345df20d0a85b90e6703fba5582cacc5ba38a6d: 8280131: jcmd reports "Module jdk.jfr not found." when "jdk.management.jfr" is missing
  • ... and 131 more: https://git.openjdk.org/jdk/compare/ac1941425bdb1a25aa3364eef9eb1092ee716761...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@LanceAndersen, @bchristi-git, @naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar Oct 20 '22 19:10 openjdk[bot]

/integrate

justin-curtis-lu avatar Oct 21 '22 21:10 justin-curtis-lu

@justin-curtis-lu Your change (at version 781b352de32d775bbf249b45541a4986d39b23e9) is now ready to be sponsored by a Committer.

openjdk[bot] avatar Oct 21 '22 21:10 openjdk[bot]

/sponsor

bchristi-git avatar Oct 21 '22 22:10 bchristi-git

Going to push as commit 902162ca9f0fc589b888e73862275554691697f4. Since your change was applied there have been 141 commits pushed to the master branch:

  • f5dabf94400b0a6082bc2eaf3ff33a11a36ad138: 8295088: Update External Spec page to show tabs for hosts
  • 218104247e2ae26ad8221f4dd78be1170b952be0: 8295375: debug agent class tracking should not piggy back on the cbClassPrepare() callback
  • f41711ef63d1a14392bf5e5b9ae6939f8772e803: 8295650: JFR: jfr scrub should warn if an event type doesn't exist
  • 0c13d66622a8c2be654bb867aa8c17421d1557ca: 8295530: Update Zlib Data Compression Library to Version 1.2.13
  • 15bebf922fb3fe46b755c85bc0a459b3c1e34c98: 8295666: Linux x86 build fails after 8292591
  • 50647187e8b0314ad67b0767f71c56fd50e8feaf: 8294460: CodeSection::alignment checks for CodeBuffer::SECT_STUBS incorrectly
  • 8b010e014c44ffb728b7a8343d3298466f5252fa: 8030616: sun/management/jmxremote/bootstrap/RmiBootstrapTest fails intermittently with cannot find a free port
  • b35922be6de7b848a2982d6a278dbd205fc39e6a: 8295714: GHA ::set-output is deprecated and will be removed
  • dfd2d83144fe4d78a7144acda6d9cb3e0045ea70: 8295657: SA: Allow larger object alignments
  • a345df20d0a85b90e6703fba5582cacc5ba38a6d: 8280131: jcmd reports "Module jdk.jfr not found." when "jdk.management.jfr" is missing
  • ... and 131 more: https://git.openjdk.org/jdk/compare/ac1941425bdb1a25aa3364eef9eb1092ee716761...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Oct 21 '22 22:10 openjdk[bot]

@bchristi-git @justin-curtis-lu Pushed as commit 902162ca9f0fc589b888e73862275554691697f4.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Oct 21 '22 22:10 openjdk[bot]